Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sessions_helper.cc
diff --git a/chrome/browser/sync/test/integration/sessions_helper.cc b/chrome/browser/sync/test/integration/sessions_helper.cc
index 8f9b1804aff4f337263d56c7e9fd4d2d0ba7ad71..6ab0e678236bbeb0d3799d332e4c4ad7fa580203 100644
--- a/chrome/browser/sync/test/integration/sessions_helper.cc
+++ b/chrome/browser/sync/test/integration/sessions_helper.cc
@@ -136,7 +136,7 @@ class TabEventHandler : public browser_sync::LocalSessionEventHandler {
TestTimeouts::action_max_timeout());
}
- virtual void OnLocalTabModified(
+ void OnLocalTabModified(
browser_sync::SyncedTabDelegate* modified_tab) override {
// Unwind to ensure SessionsSyncManager has processed the event.
base::MessageLoop::current()->PostTask(
@@ -144,7 +144,7 @@ class TabEventHandler : public browser_sync::LocalSessionEventHandler {
base::Bind(&TabEventHandler::QuitLoop, weak_factory_.GetWeakPtr()));
}
- virtual void OnFaviconPageUrlsUpdated(
+ void OnFaviconPageUrlsUpdated(
const std::set<GURL>& updated_page_urls) override {
// Unwind to ensure SessionsSyncManager has processed the event.
base::MessageLoop::current()->PostTask(
@@ -367,10 +367,11 @@ class CheckForeignSessionsChecker : public MultiClientStatusChangeChecker {
public:
CheckForeignSessionsChecker(int index,
const std::vector<ScopedWindowMap>& windows);
- virtual ~CheckForeignSessionsChecker();
+ ~CheckForeignSessionsChecker() override;
+
+ bool IsExitConditionSatisfied() override;
+ std::string GetDebugMessage() const override;
- virtual bool IsExitConditionSatisfied() override;
- virtual std::string GetDebugMessage() const override;
private:
int index_;
const std::vector<ScopedWindowMap>& windows_;

Powered by Google App Engine
This is Rietveld 408576698