Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 66673007: Ensure that dimensions and DPI are integers. (Closed)

Created:
7 years, 1 month ago by Jamie
Modified:
7 years, 1 month ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Ensure that dimensions and DPI are integers. They are extracted by the client plugin as ints, and the message is not forwarded to the host if they are not. TEST=Change the browser zoom level to something other than 100% and ensure that resize-to-client still works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234096

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M remoting/webapp/client_plugin_async.js View 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Jamie
PTAL
7 years, 1 month ago (2013-11-08 21:26:04 UTC) #1
Lambros
lgtm https://codereview.chromium.org/66673007/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): https://codereview.chromium.org/66673007/diff/1/remoting/webapp/client_plugin_async.js#newcode531 remoting/webapp/client_plugin_async.js:531: height: Math.floor(height * device_scale), Math.round might be slightly ...
7 years, 1 month ago (2013-11-08 22:26:32 UTC) #2
Jamie
FYI https://codereview.chromium.org/66673007/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): https://codereview.chromium.org/66673007/diff/1/remoting/webapp/client_plugin_async.js#newcode531 remoting/webapp/client_plugin_async.js:531: height: Math.floor(height * device_scale), On 2013/11/08 22:26:33, Lambros ...
7 years, 1 month ago (2013-11-08 22:29:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/66673007/1
7 years, 1 month ago (2013-11-08 22:30:44 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 04:43:57 UTC) #5
Message was sent while issue was closed.
Change committed as 234096

Powered by Google App Engine
This is Rietveld 408576698