Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: arguments/src/arm/codegen-arm.cc

Issue 6667076: Remove arguments shadow from scopes, stop rewriting parameters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | arguments/src/arm/full-codegen-arm.cc » ('j') | arguments/src/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: arguments/src/arm/codegen-arm.cc
diff --git a/arguments/src/arm/codegen-arm.cc b/arguments/src/arm/codegen-arm.cc
index 364f65262d0c5a65a8a443747d6986c6c1674073..04a46a0a22f4d789a58e31b4c81643d1530645a2 100644
--- a/arguments/src/arm/codegen-arm.cc
+++ b/arguments/src/arm/codegen-arm.cc
@@ -578,8 +578,6 @@ void CodeGenerator::LoadGlobalReceiver(Register scratch) {
ArgumentsAllocationMode CodeGenerator::ArgumentsMode() {
if (scope()->arguments() == NULL) return NO_ARGUMENTS_ALLOCATION;
- // In strict mode there is no need for shadow arguments.
- ASSERT(scope()->arguments_shadow() != NULL || scope()->is_strict_mode());
// We don't want to do lazy arguments allocation for functions that
// have heap-allocated contexts, because it interfers with the
// uninitialized const tracking in the context objects.
@@ -615,10 +613,7 @@ void CodeGenerator::StoreArgumentsObject(bool initial) {
}
Variable* arguments = scope()->arguments();
- Variable* shadow = scope()->arguments_shadow();
ASSERT(arguments != NULL && arguments->AsSlot() != NULL);
- ASSERT((shadow != NULL && shadow->AsSlot() != NULL) ||
- scope()->is_strict_mode());
JumpTarget done;
if (mode == LAZY_ARGUMENTS_ALLOCATION && !initial) {
@@ -633,9 +628,6 @@ void CodeGenerator::StoreArgumentsObject(bool initial) {
}
StoreToSlot(arguments->AsSlot(), NOT_CONST_INIT);
if (mode == LAZY_ARGUMENTS_ALLOCATION) done.Bind();
- if (shadow != NULL) {
- StoreToSlot(shadow->AsSlot(), NOT_CONST_INIT);
- }
}
« no previous file with comments | « no previous file | arguments/src/arm/full-codegen-arm.cc » ('j') | arguments/src/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698