Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: arguments/src/x64/codegen-x64.cc

Issue 6667076: Remove arguments shadow from scopes, stop rewriting parameters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: arguments/src/x64/codegen-x64.cc
diff --git a/arguments/src/x64/codegen-x64.cc b/arguments/src/x64/codegen-x64.cc
index 21c90a1f164ddd56fa820b5c80aa85e7f675b30c..793b6aca5fb0d9bb09979be2c6e1e205f1297ea7 100644
--- a/arguments/src/x64/codegen-x64.cc
+++ b/arguments/src/x64/codegen-x64.cc
@@ -612,8 +612,6 @@ void CodeGenerator::LoadTypeofExpression(Expression* expr) {
ArgumentsAllocationMode CodeGenerator::ArgumentsMode() {
if (scope()->arguments() == NULL) return NO_ARGUMENTS_ALLOCATION;
- // In strict mode there is no need for shadow arguments.
- ASSERT(scope()->arguments_shadow() != NULL || scope()->is_strict_mode());
// We don't want to do lazy arguments allocation for functions that
// have heap-allocated contexts, because it interfers with the
// uninitialized const tracking in the context objects.
@@ -643,10 +641,7 @@ Result CodeGenerator::StoreArgumentsObject(bool initial) {
}
Variable* arguments = scope()->arguments();
- Variable* shadow = scope()->arguments_shadow();
ASSERT(arguments != NULL && arguments->AsSlot() != NULL);
- ASSERT((shadow != NULL && shadow->AsSlot() != NULL) ||
- scope()->is_strict_mode());
JumpTarget done;
bool skip_arguments = false;
@@ -670,9 +665,6 @@ Result CodeGenerator::StoreArgumentsObject(bool initial) {
StoreToSlot(arguments->AsSlot(), NOT_CONST_INIT);
if (mode == LAZY_ARGUMENTS_ALLOCATION) done.Bind();
}
- if (shadow != NULL) {
- StoreToSlot(shadow->AsSlot(), NOT_CONST_INIT);
- }
return frame_->Pop();
}

Powered by Google App Engine
This is Rietveld 408576698