Separate ime_keyboard_x11.h from cc file.

This patchset only separates the header definition for ime_keyboard_x11 to .h file. After that, I will create ime_keybord_ozone.h also.  So the file structure will be:

ime_keyboard.h
fake_ime_keyboard.h
fake_ime_keyboard.cc
ime_keyboard_x11.h
ime_keyboard_x11.cc
ime_keyboard_ozone.h
ime_keyboard_ozone.cc

BUG=342336
Committed: https://crrev.com/ad9d3ccf8b22dfb0c6ddec4a1f7bd49652a72d68
Cr-Commit-Position: refs/heads/master@{#301565}

[FengYuan, 2014-10-21 07:55:41]

fengyuan@chromium.org changed reviewers:
+ nona@chromium.org

[FengYuan, 2014-10-27 03:33:47]

fengyuan@chromium.org changed reviewers:
+ shuchen@chromium.org

[FengYuan, 2014-10-27 03:57:30]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-27 03:58:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/20001

[commit-bot: I haz the power, 2014-10-27 03:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 03:58:10]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Seigo Nonaka, 2014-10-27 04:00:54]

Please write descriptions about this change.

The motivation of this CL is not clear for me.
Looks like you are extracting class definition to header file but not sure how
it is related to the refactioring(e.g. for testing purpose).

Thank you.

[FengYuan, 2014-10-27 04:10:19]

On 2014/10/27 04:00:54, Seigo Nonaka wrote:
> Please write descriptions about this change.
> 
> The motivation of this CL is not clear for me.
> Looks like you are extracting class definition to header file but not sure how
> it is related to the refactioring(e.g. for testing purpose).
> 
> Thank you.

The bug used here is a general bug id, this patchset doesn't do any refactoring,
it's only a tiny cleanup.

[Seigo Nonaka, 2014-10-27 04:19:13]

lgtm with nits.

please use following description style in Chromium patch.

-------------------------------------------------------------------
Separate ime_keyboard_x11.h from cc file.

This patchset only separates the header definition for 
ime_keyboard_x11 to .h file. After that, I will create 
ime_keybord_ozone.h also.  So the file structure will be:

ime_keyboard.h
fake_ime_keyboard.h
fake_ime_keyboard.cc
ime_keyboard_x11.h
ime_keyboard_x11.cc
ime_keyboard_ozone.h
ime_keyboard_ozone.cc

BUG=342336
-------------------------------------------------------------------

[FengYuan, 2014-10-27 05:00:19]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-27 05:00:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/20001

[commit-bot: I haz the power, 2014-10-27 05:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 05:31:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[FengYuan, 2014-10-27 05:48:06]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-27 05:48:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/20001

[commit-bot: I haz the power, 2014-10-27 06:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 06:27:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2014-10-27 09:52:01]

https://codereview.chromium.org/666693010/diff/20001/chromeos/ime/ime_keyboar...
File chromeos/ime/ime_keyboard_x11.h (right):

https://codereview.chromium.org/666693010/diff/20001/chromeos/ime/ime_keyboar...
chromeos/ime/ime_keyboard_x11.h:39: virtual ~ImeKeyboardX11() {}
Complex destructor should NOT has an inline body.

This causes clang compiling failure.

[FengYuan, 2014-10-27 12:48:05]

https://codereview.chromium.org/666693010/diff/20001/chromeos/ime/ime_keyboar...
File chromeos/ime/ime_keyboard_x11.h (right):

https://codereview.chromium.org/666693010/diff/20001/chromeos/ime/ime_keyboar...
chromeos/ime/ime_keyboard_x11.h:39: virtual ~ImeKeyboardX11() {}
On 2014/10/27 09:52:01, Shu Chen wrote:
> Complex destructor should NOT has an inline body.
> 
> This causes clang compiling failure.

Done.

[FengYuan, 2014-10-27 12:48:12]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-27 12:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/60001

[commit-bot: I haz the power, 2014-10-27 13:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 13:21:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[FengYuan, 2014-10-28 03:36:17]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-28 03:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/80001

[FengYuan, 2014-10-28 04:11:22]

The CQ bit was checked by fengyuan@chromium.org

[commit-bot: I haz the power, 2014-10-28 04:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666693010/100001

[commit-bot: I haz the power, 2014-10-28 04:58:17]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-28 04:59:21]

Patchset 6 (id:??) landed as
https://crrev.com/ad9d3ccf8b22dfb0c6ddec4a1f7bd49652a72d68
Cr-Commit-Position: refs/heads/master@{#301565}