|
|
DescriptionAdd rules for building ARM newlib nonsfi nexe with PNaCl toolchain.
BUG=http://code.google.com/p/chromium/issues/detail?id=372049
TEST=try
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=14046
Patch Set 1 #Patch Set 2 : #
Total comments: 4
Patch Set 3 : address comments #Messages
Total messages: 36 (16 generated)
mazda@chromium.org changed reviewers: + hidehiko@chromium.org, mseaborn@chromium.org
PTAL I confirmed that browser_tests passes by this change and Chrome side change using linux_arm and linux_arm_test builders. https://codereview.chromium.org/664063002/
lgtm
LGTM. Please use "BUG=http://code.google.com/p/chromium/issues/detail?id=NNNN" in NaCl changes rather than "BUG=NNNN" so that Bugdroid updates the correct issue tracker (and also because it's more copy-and-pastable). https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi File build/untrusted.gypi (right): https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi#new... build/untrusted.gypi:862: Nit: remove empty line to match the style in the rest of the file https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi#new... build/untrusted.gypi:905: ditto
Thank you for the review. > Please use "BUG=http://code.google.com/p/chromium/issues/detail?id=NNNN" > in NaCl changes rather than "BUG=NNNN" so that Bugdroid updates the correct > issue tracker (and also because it's more copy-and-pastable). Done https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi File build/untrusted.gypi (right): https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi#new... build/untrusted.gypi:862: On 2014/10/30 17:20:49, Mark Seaborn wrote: > Nit: remove empty line to match the style in the rest of the file Done. https://codereview.chromium.org/666693005/diff/20001/build/untrusted.gypi#new... build/untrusted.gypi:905: On 2014/10/30 17:20:49, Mark Seaborn wrote: > ditto Done.
The CQ bit was checked by mazda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/build...)
The CQ bit was checked by mazda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/build...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mazda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mazda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/build...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mazda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/build...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...)
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 14046 |