Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 666693005: Add rules for building ARM newlib nonsfi nexe with PNaCl toolchain. (Closed)

Created:
6 years, 2 months ago by mazda
Modified:
6 years, 1 month ago
Reviewers:
Mark Seaborn, hidehiko
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Project:
nacl
Visibility:
Public.

Description

Add rules for building ARM newlib nonsfi nexe with PNaCl toolchain. BUG=http://code.google.com/p/chromium/issues/detail?id=372049 TEST=try Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=14046

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M build/untrusted.gypi View 1 2 7 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (16 generated)
mazda
PTAL I confirmed that browser_tests passes by this change and Chrome side change using linux_arm ...
6 years, 1 month ago (2014-10-27 18:56:21 UTC) #2
hidehiko
lgtm
6 years, 1 month ago (2014-10-29 07:02:16 UTC) #3
Mark Seaborn
LGTM. Please use "BUG=http://code.google.com/p/chromium/issues/detail?id=NNNN" in NaCl changes rather than "BUG=NNNN" so that Bugdroid updates the ...
6 years, 1 month ago (2014-10-30 17:20:50 UTC) #4
mazda
Thank you for the review. > Please use "BUG=http://code.google.com/p/chromium/issues/detail?id=NNNN" > in NaCl changes rather than ...
6 years, 1 month ago (2014-10-31 02:30:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-10-31 03:09:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/builds/3477)
6 years, 1 month ago (2014-10-31 03:11:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-10-31 03:39:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_64-pnacl-spec/builds/2842)
6 years, 1 month ago (2014-10-31 03:40:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-04 01:21:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/builds/3506) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_64-pnacl-spec/builds/2862)
6 years, 1 month ago (2014-11-04 01:25:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-04 02:29:44 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_32-pnacl-spec/builds/2873)
6 years, 1 month ago (2014-11-04 02:32:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-05 04:13:17 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/builds/3521) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_64-pnacl-spec/builds/2876)
6 years, 1 month ago (2014-11-05 04:15:18 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-05 18:40:13 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_32-pnacl-spec/builds/2887) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_64-pnacl-spec/builds/2879)
6 years, 1 month ago (2014-11-05 18:42:37 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-05 19:07:36 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_perf_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_perf_panda/builds/3525) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x86_64-pnacl-spec/builds/2881)
6 years, 1 month ago (2014-11-05 19:10:07 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666693005/40001
6 years, 1 month ago (2014-11-05 19:16:36 UTC) #35
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 20:25:51 UTC) #36
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 14046

Powered by Google App Engine
This is Rietveld 408576698