Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: chrome/browser/history/web_history_service.cc

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/web_history_service.h ('k') | chrome/browser/history/web_history_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/web_history_service.cc
diff --git a/chrome/browser/history/web_history_service.cc b/chrome/browser/history/web_history_service.cc
index 1587daf0e03f7cd588c28ec17d2a060ca33d633b..e5a8014d1171e30504b67322a3d75749f3ac2041 100644
--- a/chrome/browser/history/web_history_service.cc
+++ b/chrome/browser/history/web_history_service.cc
@@ -49,8 +49,7 @@ class RequestImpl : public WebHistoryService::Request,
private OAuth2TokenService::Consumer,
private net::URLFetcherDelegate {
public:
- virtual ~RequestImpl() {
- }
+ ~RequestImpl() override {}
// Returns the response code received from the server, which will only be
// valid if the request succeeded.
@@ -59,7 +58,7 @@ class RequestImpl : public WebHistoryService::Request,
// Returns the contents of the response body received from the server.
const std::string& response_body() { return response_body_; }
- virtual bool is_pending() override { return is_pending_; }
+ bool is_pending() override { return is_pending_; }
private:
friend class history::WebHistoryService;
@@ -93,7 +92,7 @@ class RequestImpl : public WebHistoryService::Request,
}
// content::URLFetcherDelegate interface.
- virtual void OnURLFetchComplete(const net::URLFetcher* source) override {
+ void OnURLFetchComplete(const net::URLFetcher* source) override {
DCHECK_EQ(source, url_fetcher_.get());
response_code_ = url_fetcher_->GetResponseCode();
@@ -128,10 +127,9 @@ class RequestImpl : public WebHistoryService::Request,
}
// OAuth2TokenService::Consumer interface.
- virtual void OnGetTokenSuccess(
- const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override {
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override {
token_request_.reset();
DCHECK(!access_token.empty());
access_token_ = access_token;
@@ -143,9 +141,8 @@ class RequestImpl : public WebHistoryService::Request,
url_fetcher_->Start();
}
- virtual void OnGetTokenFailure(
- const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override {
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override {
token_request_.reset();
is_pending_ = false;
« no previous file with comments | « chrome/browser/history/web_history_service.h ('k') | chrome/browser/history/web_history_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698