chrome/browser/history/url_index_private_data.cc - Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/url_index_private_data.cc

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/typed_url_syncable_service_unittest.cc ('k') | chrome/browser/history/visit_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/url_index_private_data.cc

diff --git a/chrome/browser/history/url_index_private_data.cc b/chrome/browser/history/url_index_private_data.cc

index fe6d1dd8df6e30904698aa47bcf5aef0e5507457..cff18496dae68a6d4456893f385258476ca23227 100644

--- a/chrome/browser/history/url_index_private_data.cc

+++ b/chrome/browser/history/url_index_private_data.cc

@@ -84,12 +84,12 @@ class UpdateRecentVisitsFromHistoryDBTask : public HistoryDBTask {

URLIndexPrivateData* private_data,

URLID url_id);

- virtual bool RunOnDBThread(HistoryBackend* backend,

- history::HistoryDatabase* db) override;

- virtual void DoneRunOnMainThread() override;

+ bool RunOnDBThread(HistoryBackend* backend,

+ history::HistoryDatabase* db) override;

+ void DoneRunOnMainThread() override;

private:

- virtual ~UpdateRecentVisitsFromHistoryDBTask();

+ ~UpdateRecentVisitsFromHistoryDBTask() override;

// The URLIndexPrivateData that gets updated after the historyDB

// task returns.

« no previous file with comments | « chrome/browser/history/typed_url_syncable_service_unittest.cc ('k') | chrome/browser/history/visit_database_unittest.cc » ('j') | no next file with comments »