Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/history/in_memory_url_index.h

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/in_memory_url_index.h
diff --git a/chrome/browser/history/in_memory_url_index.h b/chrome/browser/history/in_memory_url_index.h
index 74b5b92625e7f40876bccffce7cd9aad30c0af29..f7806c344620ab7ddfc38621e50002998ca9ae22 100644
--- a/chrome/browser/history/in_memory_url_index.h
+++ b/chrome/browser/history/in_memory_url_index.h
@@ -106,7 +106,7 @@ class InMemoryURLIndex : public HistoryServiceObserver,
const base::FilePath& history_dir,
const std::string& languages,
HistoryClient* client);
- virtual ~InMemoryURLIndex();
+ ~InMemoryURLIndex() override;
// Opens and prepares the index of historical URL visits. If the index private
// data cannot be restored from its cache file then it is rebuilt from the
@@ -163,12 +163,12 @@ class InMemoryURLIndex : public HistoryServiceObserver,
const std::string& languages,
const std::set<std::string>& scheme_whitelist);
- virtual bool RunOnDBThread(HistoryBackend* backend,
- history::HistoryDatabase* db) override;
- virtual void DoneRunOnMainThread() override;
+ bool RunOnDBThread(HistoryBackend* backend,
+ history::HistoryDatabase* db) override;
+ void DoneRunOnMainThread() override;
private:
- virtual ~RebuildPrivateDataFromHistoryDBTask();
+ ~RebuildPrivateDataFromHistoryDBTask() override;
InMemoryURLIndex* index_; // Call back to this index at completion.
std::string languages_; // Languages for word-breaking.
@@ -235,16 +235,16 @@ class InMemoryURLIndex : public HistoryServiceObserver,
void OnCacheSaveDone(bool succeeded);
// Handles notifications of history changes.
- virtual void Observe(int notification_type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int notification_type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// HistoryServiceObserver:
- virtual void OnURLVisited(HistoryService* history_service,
- ui::PageTransition transition,
- const URLRow& row,
- const RedirectList& redirects,
- base::Time visit_time) override;
+ void OnURLVisited(HistoryService* history_service,
+ ui::PageTransition transition,
+ const URLRow& row,
+ const RedirectList& redirects,
+ base::Time visit_time) override;
// Notification handlers.
void OnURLsModified(const URLsModifiedDetails* details);
« no previous file with comments | « chrome/browser/history/in_memory_history_backend.h ('k') | chrome/browser/history/in_memory_url_index_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698