Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: chrome/browser/history/history_tab_helper.h

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service_factory.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_tab_helper.h
diff --git a/chrome/browser/history/history_tab_helper.h b/chrome/browser/history/history_tab_helper.h
index 7df8f5d38abd03acb6dcd8a8a08f5f24ae10c510..9f576d3473ee4180454973ede954fcd96fe302e1 100644
--- a/chrome/browser/history/history_tab_helper.h
+++ b/chrome/browser/history/history_tab_helper.h
@@ -19,7 +19,7 @@ struct HistoryAddPageArgs;
class HistoryTabHelper : public content::WebContentsObserver,
public content::WebContentsUserData<HistoryTabHelper> {
public:
- virtual ~HistoryTabHelper();
+ ~HistoryTabHelper() override;
// Updates history with the specified navigation. This is called by
// OnMsgNavigate to update history state.
@@ -43,16 +43,14 @@ class HistoryTabHelper : public content::WebContentsObserver,
friend class content::WebContentsUserData<HistoryTabHelper>;
// content::WebContentsObserver implementation.
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
- virtual void TitleWasSet(content::NavigationEntry* entry,
- bool explicit_set) override;
- virtual void WebContentsDestroyed() override;
+ void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) override;
+ void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override;
+ void WebContentsDestroyed() override;
// Helper function to return the history service. May return NULL.
HistoryService* GetHistoryService();
« no previous file with comments | « chrome/browser/history/history_service_factory.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698