Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/history/history_notifications.h

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_database.h ('k') | chrome/browser/history/history_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_notifications.h
diff --git a/chrome/browser/history/history_notifications.h b/chrome/browser/history/history_notifications.h
index fc21e7c2b1d055b75000cc81d44a8a5cc1cac00b..6178b99a2780a8bd79d8fe6d83f478df942501ba 100644
--- a/chrome/browser/history/history_notifications.h
+++ b/chrome/browser/history/history_notifications.h
@@ -19,7 +19,7 @@ namespace history {
// Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED.
struct URLsModifiedDetails : public HistoryDetails {
URLsModifiedDetails();
- virtual ~URLsModifiedDetails();
+ ~URLsModifiedDetails() override;
// Lists the information for each of the URLs affected. The rows will have the
// IDs that are currently in effect in the main history database.
@@ -29,7 +29,7 @@ struct URLsModifiedDetails : public HistoryDetails {
// Details for NOTIFICATION_HISTORY_URLS_DELETED.
struct URLsDeletedDetails : public HistoryDetails {
URLsDeletedDetails();
- virtual ~URLsDeletedDetails();
+ ~URLsDeletedDetails() override;
// Set when all history was deleted. False means just a subset was deleted.
bool all_history;
@@ -54,7 +54,7 @@ struct KeywordSearchUpdatedDetails : public HistoryDetails {
KeywordSearchUpdatedDetails(const URLRow& url_row,
KeywordID keyword_id,
const base::string16& term);
- virtual ~KeywordSearchUpdatedDetails();
+ ~KeywordSearchUpdatedDetails() override;
// The affected URLRow. The ID will be set to the value that is currently in
// effect in the main history database.
@@ -66,7 +66,7 @@ struct KeywordSearchUpdatedDetails : public HistoryDetails {
// Details for HISTORY_KEYWORD_SEARCH_TERM_DELETED.
struct KeywordSearchDeletedDetails : public HistoryDetails {
explicit KeywordSearchDeletedDetails(URLID url_row_id);
- virtual ~KeywordSearchDeletedDetails();
+ ~KeywordSearchDeletedDetails() override;
// The ID of the corresponding URLRow in the main history database.
URLID url_row_id;
« no previous file with comments | « chrome/browser/history/history_database.h ('k') | chrome/browser/history/history_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698