chrome/browser/history/chrome_history_client_factory.h - Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/chrome_history_client_factory.h

Issue 666673010: Standardize usage of virtual/override/final in chrome/browser/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/history/chrome_history_client.h ('k') | chrome/browser/history/delete_directive_handler.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_	5 #ifndef CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_

6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_	6 #define CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_

7	7

8 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"	8 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"

9	9

10 template <typename T>	10 template <typename T>

(...skipping 12 matching lines...) Expand all Loading...
23 // HistoryServiceObserver and can follow the regular shutdown even during	23 // HistoryServiceObserver and can follow the regular shutdown even during

24 // tests.	24 // tests.

25 static ChromeHistoryClient* GetForProfileWithoutCreating(Profile* profile);	25 static ChromeHistoryClient* GetForProfileWithoutCreating(Profile* profile);

26	26

27 static ChromeHistoryClientFactory* GetInstance();	27 static ChromeHistoryClientFactory* GetInstance();

28	28

29 private:	29 private:

30 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>;	30 friend struct DefaultSingletonTraits<ChromeHistoryClientFactory>;

31	31

32 ChromeHistoryClientFactory();	32 ChromeHistoryClientFactory();

33 virtual ~ChromeHistoryClientFactory();	33 ~ChromeHistoryClientFactory() override;

34	34

35 // BrowserContextKeyedServiceFactory:	35 // BrowserContextKeyedServiceFactory:

36 virtual KeyedService* BuildServiceInstanceFor(	36 KeyedService* BuildServiceInstanceFor(

37 content::BrowserContext* context) const override;	37 content::BrowserContext* context) const override;

38 virtual content::BrowserContext* GetBrowserContextToUse(	38 content::BrowserContext* GetBrowserContextToUse(

39 content::BrowserContext* context) const override;	39 content::BrowserContext* context) const override;

40 virtual bool ServiceIsNULLWhileTesting() const override;	40 bool ServiceIsNULLWhileTesting() const override;

41 };	41 };

42	42

43 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_	43 #endif // CHROME_BROWSER_HISTORY_CHROME_HISTORY_CLIENT_FACTORY_H_

OLD	NEW