Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 666673009: Removing NavigationClient dependencies from Tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index c48ba357ee14a3315c78c1992b0d229fc44ec15d..f3d01e5cea3e2dfdf750581bfed231094b8d354a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -31,7 +31,6 @@ import org.chromium.chrome.browser.toolbar.ToolbarModel;
import org.chromium.content.browser.ContentView;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.NavigationClient;
import org.chromium.content.browser.WebContentsObserver;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.NavigationHistory;
@@ -72,7 +71,7 @@ import java.util.concurrent.atomic.AtomicInteger;
* unless special care is taken to make sure {@link Tab#incrementIdCounterTo(int)} is called with
* the correct value across all affected {@link Activity}s.
*/
-public class Tab implements NavigationClient {
+public class Tab {
public static final int INVALID_TAB_ID = -1;
/** Used for automatically generating tab ids. */
@@ -409,7 +408,6 @@ public class Tab implements NavigationClient {
if (getWebContents() != null) getWebContents().getNavigationController().goForward();
}
- @Override
public NavigationHistory getDirectedNavigationHistory(boolean isForward, int itemLimit) {
Ted C 2014/10/23 16:23:27 I would go ahead and remove these two methods. Th
AKVT 2014/10/23 16:39:24 Done.
if (getWebContents() != null) {
return getWebContents().getNavigationController()
@@ -419,7 +417,6 @@ public class Tab implements NavigationClient {
}
}
- @Override
public void goToNavigationIndex(int index) {
if (getWebContents() != null) {
getWebContents().getNavigationController().goToNavigationIndex(index);

Powered by Google App Engine
This is Rietveld 408576698