Removing NavigationClient dependencies from Tab.

chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.ColorDrawable;
 import android.graphics.drawable.Drawable;
 import android.text.TextUtils;
 import android.view.Gravity;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
 import android.widget.BaseAdapter;
 import android.widget.HeaderViewListAdapter;
 import android.widget.ListPopupWindow;
 import android.widget.PopupWindow;
 import android.widget.TextView;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.ThreadUtils;
-import org.chromium.content.browser.NavigationClient;
+import org.chromium.content_public.browser.NavigationController;
 import org.chromium.content_public.browser.NavigationEntry;
 import org.chromium.content_public.browser.NavigationHistory;
 import org.chromium.ui.base.LocalizationUtils;
 
 import java.util.HashSet;
 import java.util.Set;
 
 /**
  * A popup that handles displaying the navigation history for a given tab.
  */
 public class NavigationPopup extends ListPopupWindow implements AdapterView.OnItemClickListener {
 
     private static final int FAVICON_SIZE_DP = 16;
 
     private static final int MAXIMUM_HISTORY_ITEMS = 8;
 
     private final Context mContext;
-    private final NavigationClient mNavigationClient;
+    private final NavigationController mNavigationController;
     private final NavigationHistory mHistory;
     private final NavigationAdapter mAdapter;
     private final ListItemFactory mListItemFactory;
 
     private final int mFaviconSize;
 
     private long mNativeNavigationPopup;
 
     /**
      * Constructs a new popup with the given history information.
      *
      * @param context The context used for building the popup.
-     * @param navigationClient The owner of the history being displayed.
+     * @param navigationController The owner of the history being displayed.

[Ted C, 2014/10/22 17:41:33]

I would update this comment

[AKVT, 2014/10/23 13:34:27]

Done.

      * @param isForward Whether to request forward navigation entries.
      */
     public NavigationPopup(
-            Context context, NavigationClient navigationClient, boolean isForward) {
+            Context context, NavigationController navigationController, boolean isForward) {
         super(context, null, android.R.attr.popupMenuStyle);
         mContext = context;
-        mNavigationClient = navigationClient;
-        mHistory = mNavigationClient.getDirectedNavigationHistory(
+        mNavigationController = navigationController;
+        mHistory = mNavigationController.getDirectedNavigationHistory(
                 isForward, MAXIMUM_HISTORY_ITEMS);
         mAdapter = new NavigationAdapter();
 
         float density = mContext.getResources().getDisplayMetrics().density;
         mFaviconSize = (int) (density * FAVICON_SIZE_DP);
 
         setModal(true);
         setInputMethodMode(PopupWindow.INPUT_METHOD_NOT_NEEDED);
         setHeight(ViewGroup.LayoutParams.WRAP_CONTENT);
         setOnItemClickListener(this);
@@ skipping 47 matching lines @@
         for (int i = 0; i < mHistory.getEntryCount(); i++) {
             NavigationEntry entry = mHistory.getEntryAtIndex(i);
             if (TextUtils.equals(url, entry.getUrl())) entry.updateFavicon((Bitmap) favicon);
         }
         mAdapter.notifyDataSetChanged();
     }
 
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
         NavigationEntry entry = (NavigationEntry) parent.getItemAtPosition(position);
-        mNavigationClient.goToNavigationIndex(entry.getIndex());
+        mNavigationController.goToNavigationIndex(entry.getIndex());
         dismiss();
     }
 
     private void updateBitmapForTextView(TextView view, Bitmap bitmap) {
         Drawable faviconDrawable = null;
         if (bitmap != null) {
             faviconDrawable = new BitmapDrawable(mContext.getResources(), bitmap);
             ((BitmapDrawable) faviconDrawable).setGravity(Gravity.FILL);
         } else {
             faviconDrawable = new ColorDrawable(Color.TRANSPARENT);
@@ skipping 86 matching lines @@
             return view;
         }
     }
 
     private static native String nativeGetHistoryUrl();
 
     private native long nativeInit();
     private native void nativeDestroy(long nativeNavigationPopup);
     private native void nativeFetchFaviconForUrl(long nativeNavigationPopup, String url);
 }