Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.h

Issue 666673007: [DevTools] Keep IP address of HttpServer as a member of DevToolsHttpHandlerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a lock for server_ip_address_. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.h
diff --git a/content/browser/devtools/devtools_http_handler_impl.h b/content/browser/devtools/devtools_http_handler_impl.h
index 9d5ed8128615f75004a2e6308285d3a8345bbfaa..27361bc703cc6a048c7a5e4151f0a681657766d4 100644
--- a/content/browser/devtools/devtools_http_handler_impl.h
+++ b/content/browser/devtools/devtools_http_handler_impl.h
@@ -12,6 +12,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/synchronization/lock.h"
#include "content/common/content_export.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/devtools_http_handler.h"
@@ -28,6 +29,7 @@ class Value;
}
namespace net {
+class IPEndPoint;
class ServerSocketFactory;
class URLRequestContextGetter;
}
@@ -119,6 +121,8 @@ class DevToolsHttpHandlerImpl
std::string frontend_url_;
const scoped_ptr<ServerSocketFactory> server_socket_factory_;
scoped_ptr<net::HttpServer> server_;
+ scoped_ptr<net::IPEndPoint> server_ip_address_;
+ base::Lock server_ip_address_lock_;
typedef std::map<int, DevToolsAgentHostClient*> ConnectionToClientMap;
ConnectionToClientMap connection_to_client_ui_;
const scoped_ptr<DevToolsHttpHandlerDelegate> delegate_;

Powered by Google App Engine
This is Rietveld 408576698