ui/events/platform/platform_event_source.cc - Issue 666673005: Explicitly coerce PostDispatchAction to uint32_t in DispatchEvent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/platform/platform_event_source.cc

Issue 666673005: Explicitly coerce PostDispatchAction to uint32_t in DispatchEvent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ui_enums

Patch Set: sigh. Windows. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/events/platform/platform_event_dispatcher.h ('K') | « ui/events/platform/platform_event_source.h ('k') | ui/events/platform/platform_event_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/platform/platform_event_source.cc

diff --git a/ui/events/platform/platform_event_source.cc b/ui/events/platform/platform_event_source.cc

index 9607ab78232e971d8b4b099829f5395b47722694..e89b20e49ac6247582b8b618d10290ab4face02f 100644

--- a/ui/events/platform/platform_event_source.cc

+++ b/ui/events/platform/platform_event_source.cc

@@ -63,7 +63,7 @@ void PlatformEventSource::RemovePlatformEventObserver(

}

uint32_t PlatformEventSource::DispatchEvent(PlatformEvent platform_event) {

- uint32_t action = POST_DISPATCH_PERFORM_DEFAULT;

+ uint32_t action = kPostDispatchPerformDefault;

FOR_EACH_OBSERVER(PlatformEventObserver, observers_,

WillProcessEvent(platform_event));

@@ -71,13 +71,13 @@ uint32_t PlatformEventSource::DispatchEvent(PlatformEvent platform_event) {

if (overridden_dispatcher_)

action = overridden_dispatcher_->DispatchEvent(platform_event);

- if ((action & POST_DISPATCH_PERFORM_DEFAULT) &&

+ if ((action & kPostDispatchPerformDefault) &&

dispatchers_.might_have_observers()) {

ObserverList<PlatformEventDispatcher>::Iterator iter(dispatchers_);

while (PlatformEventDispatcher* dispatcher = iter.GetNext()) {

if (dispatcher->CanDispatchEvent(platform_event))

action = dispatcher->DispatchEvent(platform_event);

- if (action & POST_DISPATCH_STOP_PROPAGATION)

+ if (action & kPostDispatchStopPropagation)

break;

}