Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 66663004: events: Add a new events_unittests target. (Closed)

Created:
7 years, 1 month ago by sadrul
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tdanderson
Visibility:
Public.

Description

events: Add a new events_unittests target. The tests are still included in ui_unittests too, until the events_unittests target is built and run on buildbots/trybots. BUG=316677 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234006

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -15 lines) Patch
M build/all.gyp View 1 4 chunks +7 lines, -9 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +23 lines, -1 line 0 comments Download
A + ui/events/test/events_unittests.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A ui/events/test/test_suite.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/events/test/test_suite.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
I have also removed the mac-specific rules for use_aura==1 from all.gyp
7 years, 1 month ago (2013-11-08 19:52:00 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-08 21:05:26 UTC) #2
sadrul
7 years, 1 month ago (2013-11-08 21:50:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r234006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698