CC: Decouple tile-grid-size from tile-size.

CC: Decouple tile-grid-size from tile-size.

Using the tile-size for the tile-grid-size isn't effective, since
these have different scales etc.

This patch adds a new setting such that we can start to tune this
independantly of other settings.

BUG=365877
Committed: https://crrev.com/20650a53f87a598e16affa4f9705571942bb3908
Cr-Commit-Position: refs/heads/master@{#300420}

[epenner, 2014-10-17 20:09:37]

epenner@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[epenner, 2014-10-17 20:12:26]

Ptal for last tile-size cleanup patch.

Added the test suggested in:
https://codereview.chromium.org/605773004/

[danakj, 2014-10-18 19:58:46]

https://codereview.chromium.org/666573002/diff/20001/cc/trees/layer_tree_sett...
File cc/trees/layer_tree_settings.cc (right):

https://codereview.chromium.org/666573002/diff/20001/cc/trees/layer_tree_sett...
cc/trees/layer_tree_settings.cc:52: default_tile_grid_size(gfx::Size(512, 512)),
i think we should leave this as 256,256 in this patch, and then go about
changing the value in CLs that only do that. this patch description doesn't say
anything about changing behaviour of this, and I thin that's right.

otherwise LGTM

[epennerAtGoogle, 2014-10-20 18:46:18]

epenner@google.com changed reviewers:
+ ernstm@chromium.org

[epennerAtGoogle, 2014-10-20 18:53:32]

> i think we should leave this as 256,256 in this patch, and then go about
> changing the value in CLs that only do that. this patch description doesn't
say
> anything about changing behaviour of this, and I thin that's right.
> 
> otherwise LGTM

Ahh, yeah I wasn't really thinking of trying to change it here; I was just
thinking of 512 being set on some devices when I chose this. I changed to 256.

I should mention also that we could try to make viewport or full-width tiles,
but that would still be awkward on layer size change, so I'm thinking just
trying a constant and tuning for Ganesh perf (where raster is in the critical
path), is a good first start.

[danakj, 2014-10-20 18:55:53]

There's also that size where we stop tiling, which we can make larger for
ganesh. I'm not sure if that's based off the tile size or a constant off
the top of my head.
On Oct 20, 2014 2:53 PM, <epenner@google.com> wrote:

> i think we should leave this as 256,256 in this patch, and then go about
>> changing the value in CLs that only do that. this patch description
>> doesn't
>>
> say
>
>> anything about changing behaviour of this, and I thin that's right.
>>
>
>  otherwise LGTM
>>
>
> Ahh, yeah I wasn't really thinking of trying to change it here; I was just
> thinking of 512 being set on some devices when I chose this. I changed to
> 256.
>
> I should mention also that we could try to make viewport or full-width
> tiles,
> but that would still be awkward on layer size change, so I'm thinking just
> trying a constant and tuning for Ganesh perf (where raster is in the
> critical
> path), is a good first start.
>
> https://codereview.chromium.org/666573002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[epennerAtGoogle, 2014-10-20 19:00:43]

On 2014/10/20 18:55:53, danakj wrote:
> There's also that size where we stop tiling, which we can make larger for
> ganesh. I'm not sure if that's based off the tile size or a constant off
> the top of my head.

That's all relative now for Ganesh as of my last patches, using the viewport. At
least until we think of something better.

So now the only setting that's manually tuned for Ganesh is the tile-grid.

[danakj, 2014-10-20 22:17:30]

On 2014/10/20 19:00:43, epennerAtGoogle wrote:
> On 2014/10/20 18:55:53, danakj wrote:
> > There's also that size where we stop tiling, which we can make larger for
> > ganesh. I'm not sure if that's based off the tile size or a constant off
> > the top of my head.
> 
> That's all relative now for Ganesh as of my last patches, using the viewport.
At
> least until we think of something better.
> 
> So now the only setting that's manually tuned for Ganesh is the tile-grid.

Cool! Nice job. LGTM

[epenner, 2014-10-21 02:23:47]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-10-21 02:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666573002/60001

[commit-bot: I haz the power, 2014-10-21 04:29:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-21 04:29:53]

Patchset 4 (id:??) landed as
https://crrev.com/20650a53f87a598e16affa4f9705571942bb3908
Cr-Commit-Position: refs/heads/master@{#300420}