Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 666563007: Revert of Use src-side launcher for telemetry_unittests in chromium_trybot recipe (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'chromium', 7 'chromium',
8 'chromium_tests', 8 'chromium_tests',
9 'gclient', 9 'gclient',
10 'isolate', 10 'isolate',
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 compile_targets, gtest_tests = parse_test_spec( 787 compile_targets, gtest_tests = parse_test_spec(
788 test_spec, 788 test_spec,
789 bot_config.get('enable_swarming'), 789 bot_config.get('enable_swarming'),
790 should_use_test) 790 should_use_test)
791 compile_targets.extend(bot_config.get('compile_targets', [])) 791 compile_targets.extend(bot_config.get('compile_targets', []))
792 # TODO(phajdan.jr): Also compile 'all' on win, http://crbug.com/368831 . 792 # TODO(phajdan.jr): Also compile 'all' on win, http://crbug.com/368831 .
793 # Disabled for now because it takes too long and/or fails on Windows. 793 # Disabled for now because it takes too long and/or fails on Windows.
794 if not api.platform.is_win and not bot_config.get('exclude_compile_all'): 794 if not api.platform.is_win and not bot_config.get('exclude_compile_all'):
795 compile_targets = ['all'] + compile_targets 795 compile_targets = ['all'] + compile_targets
796 796
797 scripts_compile_targets = \
798 api.chromium.get_compile_targets_for_scripts().json.output
799
800 # Tests that are only run if their compile_targets are going to be built. 797 # Tests that are only run if their compile_targets are going to be built.
801 conditional_tests = [api.chromium.steps.NaclIntegrationTest()] 798 conditional_tests = [api.chromium.steps.NaclIntegrationTest()]
802 if bot_config.get('add_telemetry_tests', True): 799 if bot_config.get('add_telemetry_tests', True):
803 conditional_tests += [ 800 conditional_tests += [api.chromium.steps.TelemetryUnitTests(),
804 api.chromium.steps.ScriptTest( 801 api.chromium.steps.TelemetryPerfUnitTests()]
805 'telemetry_unittests', 'telemetry_unittests.py',
806 scripts_compile_targets),
807 api.chromium.steps.TelemetryPerfUnitTests()
808 ]
809 802
810 # See if the patch needs to compile on the current platform. 803 # See if the patch needs to compile on the current platform.
811 # Don't run analyze for other projects, such as blink, as there aren't that 804 # Don't run analyze for other projects, such as blink, as there aren't that
812 # many try jobs for them. 805 # many try jobs for them.
813 requires_compile = True 806 requires_compile = True
814 if isinstance(test_spec, dict) and api.properties.get('root') == 'src': 807 if isinstance(test_spec, dict) and api.properties.get('root') == 'src':
815 analyze_config_file = bot_config['testing'].get('analyze_config_file', 808 analyze_config_file = bot_config['testing'].get('analyze_config_file',
816 'trybot_analyze_config.json') 809 'trybot_analyze_config.json')
817 requires_compile, matching_exes, compile_targets = \ 810 requires_compile, matching_exes, compile_targets = \
818 api.chromium_tests.analyze( 811 api.chromium_tests.analyze(
819 get_test_names(gtest_tests) + 812 get_test_names(gtest_tests) +
820 all_compile_targets(api, conditional_tests), 813 all_compile_targets(api, conditional_tests),
821 compile_targets, 814 compile_targets,
822 analyze_config_file) 815 analyze_config_file)
823 816
824 gtest_tests = filter_tests(gtest_tests, matching_exes) 817 gtest_tests = filter_tests(gtest_tests, matching_exes)
825 818
826 tests = [] 819 tests = []
827 # TODO(phajdan.jr): Re-enable checkdeps on Windows when it works with git. 820 # TODO(phajdan.jr): Re-enable checkdeps on Windows when it works with git.
828 if not api.platform.is_win: 821 if not api.platform.is_win:
829 tests.append(api.chromium.steps.ScriptTest( 822 tests.append(api.chromium.steps.ScriptTest('checkdeps', 'checkdeps.py'))
830 'checkdeps', 'checkdeps.py', scripts_compile_targets))
831 if api.platform.is_linux: 823 if api.platform.is_linux:
832 tests.extend([ 824 tests.extend([
833 api.chromium.steps.CheckpermsTest(), 825 api.chromium.steps.CheckpermsTest(),
834 api.chromium.steps.ChecklicensesTest(), 826 api.chromium.steps.ChecklicensesTest(),
835 ]) 827 ])
836 828
837 conditional_tests = tests_in_compile_targets( 829 conditional_tests = tests_in_compile_targets(
838 api, compile_targets, conditional_tests) 830 api, compile_targets, conditional_tests)
839 tests.extend(find_test_named('telemetry_unittests', conditional_tests)) 831 tests.extend(find_test_named(api.chromium.steps.TelemetryUnitTests.name,
832 conditional_tests))
840 tests.extend(find_test_named(api.chromium.steps.TelemetryPerfUnitTests.name, 833 tests.extend(find_test_named(api.chromium.steps.TelemetryPerfUnitTests.name,
841 conditional_tests)) 834 conditional_tests))
842 tests.extend(gtest_tests) 835 tests.extend(gtest_tests)
843 tests.extend(find_test_named(api.chromium.steps.NaclIntegrationTest.name, 836 tests.extend(find_test_named(api.chromium.steps.NaclIntegrationTest.name,
844 conditional_tests)) 837 conditional_tests))
845 838
846 if api.platform.is_win: 839 if api.platform.is_win:
847 tests.append(api.chromium.steps.MiniInstallerTest()) 840 tests.append(api.chromium.steps.MiniInstallerTest())
848 841
849 if not requires_compile: 842 if not requires_compile:
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
1566 }, 1559 },
1567 ], 1560 ],
1568 }) 1561 })
1569 ) + 1562 ) +
1570 api.override_step_data( 1563 api.override_step_data(
1571 'analyze', 1564 'analyze',
1572 api.json.output({'status': 'Found dependency', 1565 api.json.output({'status': 'Found dependency',
1573 'targets': ['browser_tests', 'base_unittests'], 1566 'targets': ['browser_tests', 'base_unittests'],
1574 'build_targets': ['base_unittests']})) 1567 'build_targets': ['base_unittests']}))
1575 ) 1568 )
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/chromium/steps.py ('k') | scripts/slave/recipes/chromium_trybot.expected/arm.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698