Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 666563004: Restore code removed temporarily for refactoring on WebApplicationCacheHost in Blink (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restore code removed temporarily for refactoring on WebApplicationCacheHost in Blink To land Blink 183121 which changes the signature of WebApplicationCacheHost::didReceiveDataForMainResource(), we had to duplicate implementation in Chromium side. We chose to just remove the implementation temporarily and restore after the Blink side change gets rolled since the implementation was empty. BUG=418885 Committed: https://crrev.com/4ff13d2f9ec739eebc23f44d14296fb6a4c16871 Cr-Commit-Position: refs/heads/master@{#300854}

Patch Set 1 #

Patch Set 2 : Revert override #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/child/appcache/web_application_cache_host_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-22 06:48:27 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-10-22 22:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666563004/40001
6 years, 2 months ago (2014-10-23 05:56:26 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-23 07:50:54 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 07:51:40 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ff13d2f9ec739eebc23f44d14296fb6a4c16871
Cr-Commit-Position: refs/heads/master@{#300854}

Powered by Google App Engine
This is Rietveld 408576698