Issue 666563003: Delete the last remaining use of OVERRIDE and remove its definition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 666563003: Delete the last remaining use of OVERRIDE and remove its definition. (Closed)

Created:
6 years, 2 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
dominich, Lei Zhang

CC:
chromium-reviews, shishir+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Delete the last remaining use of OVERRIDE and remove its definition. TBR=dominich@chromium.org,thestig@chromium.org BUG=417463 Committed: https://crrev.com/161168015de91abe74ba7be393a12a63f99a0636 Cr-Commit-Position: refs/heads/master@{#300642}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	base/compiler_specific.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	chrome/browser/predictors/resource_prefetch_common_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

viettrungluu

This may still fail, but I'm going to hit the CQ button in case it ...

6 years, 2 months ago (2014-10-22 05:17:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666563003/1

6 years, 2 months ago (2014-10-22 05:18:08 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/161168015de91abe74ba7be393a12a63f99a0636 Cr-Commit-Position: refs/heads/master@{#300642}

6 years, 2 months ago (2014-10-22 06:48:51 UTC) #5

Message was sent while issue was closed.

lgtm