components/constrained_window/constrained_window_views.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/constrained_window/constrained_window_views.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/app_modal_dialogs/cocoa/DEPS ('K') | « components/app_modal_dialogs/views/javascript_app_modal_dialog_views.cc ('k') | extensions/components/extensions_components.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/constrained_window/constrained_window_views.cc

diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc

index 11a4f6323a4b851309d50ceac1a386fc07d3dff0..7c7109e9f2f80f47bd607e9e8330ee3ce5895981 100644

--- a/components/constrained_window/constrained_window_views.cc

+++ b/components/constrained_window/constrained_window_views.cc

@@ -153,7 +153,7 @@ views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,

// TODO(gbillock): Replace this with PopupManager calls.

views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,

- gfx::NativeView parent) {

+ gfx::NativeWindow parent) {

msw 2014/11/05 22:59:06 nit: fix this indent.

oshima 2014/11/05 23:22:49 reverted.

views::Widget* widget =

views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent);

if (!dialog->UseNewStyleForThisDialog())