chrome/browser/ui/views/simple_message_box_views.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('K') | « chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc ('k') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc » ('j') | chrome/browser/ui/views/update_recommended_message_box.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index 3812aee7459426435b3702e1aa701fbda33cfa27..e1d84faf2c3a31e3e79264ae6c9844cfb2a84192 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -235,7 +235,7 @@ MessageBoxResult ShowMessageBoxImpl(gfx::NativeWindow parent,

no_text,

parent == NULL // is_system_modal

);

- CreateBrowserModalDialogViews(dialog, parent)->Show();

+ CreateAppModalDialogViews(dialog, parent)->Show();

// NOTE: |dialog| may have been deleted by the time |RunDialogAndGetResult()|

// returns.