Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: components/app_modal_dialogs/javascript_native_dialog_factory.h

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: similarity=30 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal_dialogs/javascript_native_dialog_factory.h
diff --git a/chrome/browser/ui/native_window_tracker.h b/components/app_modal_dialogs/javascript_native_dialog_factory.h
similarity index 30%
copy from chrome/browser/ui/native_window_tracker.h
copy to components/app_modal_dialogs/javascript_native_dialog_factory.h
index c08dc126546b766861acc8cecc5d0097a5f93d28..3944a6186fc09a0599b9eddfd02ec1b656556864 100644
--- a/chrome/browser/ui/native_window_tracker.h
+++ b/components/app_modal_dialogs/javascript_native_dialog_factory.h
@@ -2,21 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_NATIVE_WINDOW_TRACKER_H_
-#define CHROME_BROWSER_UI_NATIVE_WINDOW_TRACKER_H_
+#ifndef COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_NATIVE_DIALOG_FACTORY_H_
+#define COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_NATIVE_DIALOG_FACTORY_H_
+
+#include <string>
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/native_widget_types.h"
-// An observer which detects when a gfx::NativeWindow is closed.
-class NativeWindowTracker {
- public:
- virtual ~NativeWindowTracker() {}
+class GURL;
+class JavaScriptAppModalDialog;
+class NativeAppModalDialog;
- static scoped_ptr<NativeWindowTracker> Create(gfx::NativeWindow window);
+class JavaScriptNativeDialogFactory {
+ public:
+ virtual ~JavaScriptNativeDialogFactory() {}
- // Returns true if the native window passed to Create() has been closed.
- virtual bool WasNativeWindowClosed() const = 0;
+ // Creates an native modal dialog for a JavaScript dialog;
+ virtual NativeAppModalDialog* CreateNativeJavaScriptDialog(
+ JavaScriptAppModalDialog* dialog,
+ gfx::NativeWindow parent_window) = 0;
};
-#endif // CHROME_BROWSER_UI_NATIVE_WINDOW_TRACKER_H_
+#endif // COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_NATIVE_DIALOG_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698