components/app_modal_dialogs/BUILD.gn - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal_dialogs/BUILD.gn

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: similarity=30 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('K') | « components/app_modal_dialogs.gypi ('k') | components/app_modal_dialogs/DEPS » ('j') | components/app_modal_dialogs/javascript_dialog_extensions_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal_dialogs/BUILD.gn

diff --git a/components/app_modal_dialogs/BUILD.gn b/components/app_modal_dialogs/BUILD.gn

index 34d10af3c797f09b071ee30901f3f842f054d08e..ef2f9329bad78e272a927301889c25a0ca5a26b1 100644

--- a/components/app_modal_dialogs/BUILD.gn

+++ b/components/app_modal_dialogs/BUILD.gn

@@ -8,21 +8,35 @@ static_library("app_modal_dialogs") {

sources = [

"app_modal_dialog.cc",

"app_modal_dialog.h",

- "app_modal_dialog_test_util.h",

"app_modal_dialog_queue.cc",

"app_modal_dialog_queue.h",

+ "app_modal_dialog_test_util.h",

"javascript_app_modal_dialog.cc",

"javascript_app_modal_dialog.h",

+ "javascript_dialog_extension_client.h",

+ "javascript_dialog_manager.cc",

+ "javascript_dialog_manager.h",

+ "javascript_dialog_manager_impl.cc",

+ "javascript_dialog_manager_impl.h",

+ "javascript_native_dialog_factory.h",

"native_app_modal_dialog.h"

]

deps = [

"//components/strings",

"//content/public/browser",

+ "//content/public/common",

"//skia",

]

if (use_aura) {

deps += [ "//ui/aura" ]

}

+ if (toolkit_views && !is_mac) {

+ sources += [

+ "views/javascript_app_modal_dialog_views.h",

+ "views/javascript_app_modal_dialog_views.cc",

+ ]

+ }

}