chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc ('K') | « chrome/browser/ui/views/simple_message_box_views.cc ('k') | chrome/browser/ui/views/update_recommended_message_box.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

index becfd99e0c50b35c000ced257021173da2fa08d2..1c408afe6a8487e3da6541c8fb5555effd0c50c0 100644

--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

@@ -91,7 +91,7 @@ void ProfileSigninConfirmationDialogViews::ShowDialog(

void ProfileSigninConfirmationDialogViews::Show(bool prompt_for_new_profile) {

prompt_for_new_profile_ = prompt_for_new_profile;

- CreateBrowserModalDialogViews(

+ CreateWindowModalDialogViews(

this, browser_->window()->GetNativeWindow())->Show();

}