chrome/browser/ui/browser.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h ('K') | « chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc ('k') | chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm » ('j') | chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 940e87b05f81253c95a00457da52f1a936283b5a..45257c28e330605ec523233f8a82d6b903a4f6aa 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -85,7 +85,6 @@

#include "chrome/browser/themes/theme_service.h"

#include "chrome/browser/themes/theme_service_factory.h"

#include "chrome/browser/translate/chrome_translate_client.h"

-#include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h"

#include "chrome/browser/ui/autofill/chrome_autofill_client.h"

#include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"

#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"

@@ -152,6 +151,7 @@

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

#include "chrome/grit/locale_settings.h"

+#include "components/app_modal_dialogs/javascript_dialog_manager.h"

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/bookmarks/browser/bookmark_utils.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"