chrome/browser/ui/views/external_protocol_dialog.cc - Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/app_modal_dialogs/chrome_javascript_dialog_manager_client.h ('K') | « chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc ('k') | chrome/browser/ui/views/javascript_app_modal_dialog_views.h » ('j') | components/app_modal_dialogs.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/external_protocol_dialog.h"	5 #include "chrome/browser/ui/views/external_protocol_dialog.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "base/strings/string_util.h"	8 #include "base/strings/string_util.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/browser/external_protocol/external_protocol_handler.h"	10 #include "chrome/browser/external_protocol/external_protocol_handler.h"

(...skipping 117 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
128 params.message_width = kMessageWidth;	128 params.message_width = kMessageWidth;

129 message_box_view_ = new views::MessageBoxView(params);	129 message_box_view_ = new views::MessageBoxView(params);

130 message_box_view_->SetCheckBoxLabel(delegate_->GetCheckboxText());	130 message_box_view_->SetCheckBoxLabel(delegate_->GetCheckboxText());

131	131

132 // Dialog is top level if we don't have a web_contents associated with us.	132 // Dialog is top level if we don't have a web_contents associated with us.

133 WebContents* web_contents = tab_util::GetWebContentsByID(	133 WebContents* web_contents = tab_util::GetWebContentsByID(

134 render_process_host_id_, routing_id_);	134 render_process_host_id_, routing_id_);

135 gfx::NativeWindow parent_window = NULL;	135 gfx::NativeWindow parent_window = NULL;

136 if (web_contents)	136 if (web_contents)

137 parent_window = web_contents->GetTopLevelNativeWindow();	137 parent_window = web_contents->GetTopLevelNativeWindow();

138 CreateBrowserModalDialogViews(this, parent_window)->Show();	138 CreateWindowModalDialogViews(this, parent_window)->Show();

139 }	139 }

OLD	NEW