Use more accurate strings for plug-in content settings.

Use more accurate strings for plug-in content settings.

"Block all" really means "Right-click to play".

BUG=251024
Committed: https://crrev.com/826e7f6db664fd9f04f63192026afd4b5ec6a437
Cr-Commit-Position: refs/heads/master@{#300558}

[palmer, 2014-10-17 23:43:01]

palmer@chromium.org changed reviewers:
+ ainslie@chromium.org, estade@chromium.org

[palmer, 2014-10-17 23:43:02]

Although not perfect — the true solution to this problem, if there is one, will
take longer — this change at least makes the strings and code identifier
minimally accurate.

[Evan Stade, 2014-10-18 00:21:49]

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7833: +          Option-click to play
isn't there some weird icon for "Option"?

[palmer, 2014-10-18 00:43:27]

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7833: +          Option-click to play
> isn't there some weird icon for "Option"?

No, that's Command (⌘).

[Evan Stade, 2014-10-18 01:38:55]

http://macbiblioblog.blogspot.com/2005/05/special-key-symbols.html?m=1

The option key has one as well, although I admittedly don't know if we want
to use it.
On Oct 17, 2014 5:43 PM, <palmer@chromium.org> wrote:

>
> https://codereview.chromium.org/666523004/diff/1/chrome/
> app/generated_resources.grd
> File chrome/app/generated_resources.grd (right):
>
> https://codereview.chromium.org/666523004/diff/1/chrome/
> app/generated_resources.grd#newcode7833
> chrome/app/generated_resources.grd:7833: +          Option-click to play
>
>> isn't there some weird icon for "Option"?
>>
>
> No, that's Command (⌘).
>
> https://codereview.chromium.org/666523004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bernhard Bauer, 2014-10-20 09:40:48]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2014-10-20 09:40:48]

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7833: +          Option-click to play
Option-click doesn't open a context menu on Mac, Ctrl-click does. But so does
right-clicking, for that matter (assuming that the mouse is set to right-handed,
otherwise it's left-clicking; that's why it's technically "secondary mouse
button"). And really, neither of right-clicking or ctrl-clicking immediately
runs the plugin, it just opens the context menu where you can choose to run the
plugin. If we want to make this accurate, how about "Run via context menu"?

[Evan Stade, 2014-10-20 15:05:17]

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7833: +          Option-click to play
On 2014/10/20 09:40:48, Bernhard Bauer wrote:
> Option-click doesn't open a context menu on Mac, Ctrl-click does. But so does
> right-clicking, for that matter (assuming that the mouse is set to
right-handed,
> otherwise it's left-clicking; that's why it's technically "secondary mouse
> button"). And really, neither of right-clicking or ctrl-clicking immediately
> runs the plugin, it just opens the context menu where you can choose to run
the
> plugin. If we want to make this accurate, how about "Run via context menu"?

Do people know what a 'context menu' is? I think "Right click to play" makes
sense; it's shorthand for "you must right click in order to play", which is
true, although it's not the only step.

[Bernhard Bauer, 2014-10-20 15:25:40]

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:7833: +          Option-click to play
On 2014/10/20 15:05:17, Evan Stade wrote:
> On 2014/10/20 09:40:48, Bernhard Bauer wrote:
> > Option-click doesn't open a context menu on Mac, Ctrl-click does. But so
does
> > right-clicking, for that matter (assuming that the mouse is set to
> right-handed,
> > otherwise it's left-clicking; that's why it's technically "secondary mouse
> > button"). And really, neither of right-clicking or ctrl-clicking immediately
> > runs the plugin, it just opens the context menu where you can choose to run
> the
> > plugin. If we want to make this accurate, how about "Run via context menu"?
> 
> Do people know what a 'context menu' is? I think "Right click to play" makes
> sense; it's shorthand for "you must right click in order to play", which is
> true, although it's not the only step.

My guess is that the number of people who know what a context menu is is bigger
than the number of people who know what a plugin is...

The Apple HIG actually only mentions "Control-clicking" (with "Control"
capitalized and spelled out) as the way to open a contextual menu. If we don't
want to directly mention the menu, I would then go with "Control-click to play".

[Evan Stade, 2014-10-20 15:31:57]

On 2014/10/20 15:25:40, Bernhard Bauer wrote:
>
https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/666523004/diff/1/chrome/app/generated_resourc...
> chrome/app/generated_resources.grd:7833: +          Option-click to play
> On 2014/10/20 15:05:17, Evan Stade wrote:
> > On 2014/10/20 09:40:48, Bernhard Bauer wrote:
> > > Option-click doesn't open a context menu on Mac, Ctrl-click does. But so
> does
> > > right-clicking, for that matter (assuming that the mouse is set to
> > right-handed,
> > > otherwise it's left-clicking; that's why it's technically "secondary mouse
> > > button"). And really, neither of right-clicking or ctrl-clicking
immediately
> > > runs the plugin, it just opens the context menu where you can choose to
run
> > the
> > > plugin. If we want to make this accurate, how about "Run via context
menu"?
> > 
> > Do people know what a 'context menu' is? I think "Right click to play" makes
> > sense; it's shorthand for "you must right click in order to play", which is
> > true, although it's not the only step.
> 
> My guess is that the number of people who know what a context menu is is
bigger
> than the number of people who know what a plugin is...
> 
> The Apple HIG actually only mentions "Control-clicking" (with "Control"
> capitalized and spelled out) as the way to open a contextual menu. If we don't
> want to directly mention the menu, I would then go with "Control-click to
play".

The Apple HIG is designed for consumption by developers, not users. The
shortcuts in menus use the symbols. But perhaps this is a question for the mac
team.

[Bernhard Bauer, 2014-10-20 15:37:27]

From what I could find on
http://support.apple.com/kb/index?page=search&locale=en_US&src=support_site.k...,
Apple help also seems to use "Control-click". The only references to
"Ctrl-click" I could find were in user support forums.

[Evan Stade, 2014-10-20 15:43:05]

On 2014/10/20 15:37:27, Bernhard Bauer wrote:
> From what I could find on
>
http://support.apple.com/kb/index?page=search&locale=en_US&src=support_site.k...,
> Apple help also seems to use "Control-click". The only references to
> "Ctrl-click" I could find were in user support forums.

fair enough, Control-click it is.

[palmer, 2014-10-20 18:31:01]

> fair enough, Control-click it is.

Done.

[palmer, 2014-10-20 19:35:37]

palmer@chromium.org changed reviewers:
+ glen@chromium.org

[palmer, 2014-10-20 19:35:37]

Glen, LGTY?

[Bernhard Bauer, 2014-10-20 20:02:49]

In addition, we could change the string inside of a blocked plugin placeholder
to say something like "Right-click to play <plugin>" or something.

[palmer, 2014-10-20 21:45:25]

> In addition, we could change the string inside of a blocked plugin placeholder
> to say something like "Right-click to play <plugin>" or something.

Good idea. But, any idea where that string (e.g. "Chrome PDF Viewer is not
allowed") is defined? I can't find it in a seemingly exhaustive search.

~/chromium/src $ search -n '\.grd$' -c 'is not allowed' -v
./chrome/app/generated_resources.grd:2344:      <message
name="IDS_BLOCKED_COOKIES_TITLE" desc="Tooltip and bubble info header text when
a page is not allowed to write cookies or other site data.">
./chrome/app/generated_resources.grd:2356:      <message
name="IDS_BLOCKED_IMAGES_TITLE" desc="Tooltip and bubble info header text when a
page is not allowed to display images.">
./chrome/app/generated_resources.grd:2374:      <message
name="IDS_BLOCKED_POPUPS_TOOLTIP" desc="Tooltip text when a page is not allowed
to display popups.">
./chrome/app/generated_resources.grd:2377:      <message
name="IDS_BLOCKED_POPUPS_TITLE" desc="Bubble info header text when a page is not
allowed to display popups.  This appears above a list of popup titles.">
./chrome/app/generated_resources.grd:2440:      <message
name="IDS_BLOCKED_JAVASCRIPT_TITLE" desc="Tooltip and bubble info header text
when a page is not allowed to run JavaScript.">
./chrome/app/generated_resources.grd:2453:        <message
name="IDS_BLOCKED_PLUGINS_TITLE" desc="Bubble info header text when a page is
not allowed to display plug-ins.">
./chrome/app/generated_resources.grd:2457:      <message
name="IDS_BLOCKED_PLUGINS_MESSAGE" desc="Tooltip and message when a page is not
allowed to display plug-ins.">
./chrome/app/generated_resources.grd:4545:        <message
name="IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT" desc="Error message
when a user tries to install or the administrator tries to force-install through
policy an extension that is not allowed in a device-local account.">
./chrome/app/generated_resources.grd:4546:          <ph
name="EXTENSION_NAME">$1<ex>Google Talk</ex></ph> (extension ID "<ph
name="EXTENSION_ID">$2<ex>nckgahadagoaajjgafhacjanaoiihapd</ex></ph>") is not
allowed in this type of session.
./chrome/app/generated_resources.grd:4564:      <message
name="IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE" desc="Error displayed during
installation of an extension when installation is not allowed from the current
site.">
./chrome/app/generated_resources.grd:4580:        Unable to install "<ph
name="APP_NAME">$1<ex>Google Play Movies &amp; TV</ex></ph>" because it is not
allowed by "<ph name="IMPORT_NAME">$2<ex>Google Cast API</ex></ph>"
./chrome/app/generated_resources.grd:6819:        <ph
name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is not allowed.
./chrome/app/generated_resources.grd:11653:      <message
name="IDS_SYNC_LOGIN_NAME_PROHIBITED" desc="The error message shown when the
user tries to sign in to sync using a name that is not allowed by the admin
policy">
./chrome/app/generated_resources.grd:12337:          Empty passphrase is not
allowed.
./chrome/app/generated_resources.grd:14733:    <message
name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_PHONE_UNLOCKABLE" desc="Tooltip for an
icon on a user's lock screen pod shown by Easy Unlock when a phone eligible to
unlock the Chromebook is detected, but it does not have lock screen enabled, in
which case it is not allowed to unlock Chromebooks.">
./chrome/app/generated_resources.grd

~/chromium/src $ search -x/out/ -c 'is not allowed'                             
                                                                                
                                         

~/chromium/src $

Note that IDS_BLOCKED_PLUGINS_MESSAGE and friends, which seems likely, are:

      <if expr="is_macosx">
        <message name="IDS_BLOCKED_PLUGINS_TITLE" desc="Bubble info header text
when a page is not allowed to display plug-ins.">
          The following plug-ins were blocked on this page:
        </message>
      </if>
      <message name="IDS_BLOCKED_PLUGINS_MESSAGE" desc="Tooltip and message when
a page is not allowed to display plug-ins.">
        Plug-ins were blocked on this page.
      </message>
      <message name="IDS_BLOCKED_PLUGINS_UNBLOCK_ALL" desc="Radio button choice
to unblock a site from using plug-ins, displayed in bubble when a page tries to
use plug-ins.">
        Always allow plug-ins on <ph name="HOST">$1<ex>mail.google.com</ex></ph>
      </message>
      <if expr="is_macosx">
        <message name="IDS_BLOCKED_PLUGINS_UNBLOCK" desc="Radio button choice to
unblock a site from using *a specific set* of plug-ins, displayed in bubble when
a page tries to use plug-ins.">
          Always allow these plug-ins on <ph
name="HOST">$1<ex>mail.google.com</ex></ph>
        </message>
      </if>
      <message name="IDS_BLOCKED_PLUGINS_NO_ACTION" desc="Radio button choice to
continue blocking a site from using plug-ins, displayed in bubble when a page
tries to use plug-ins.">
        Continue blocking plug-ins
      </message>
      <message name="IDS_BLOCKED_PLUGINS_LINK" desc="Link to plug-ins section of
content blocking management dialog, displayed in bubble when a page tries to
display plug-ins.">
        Manage plug-in blocking...
      </message>
      <message name="IDS_BLOCKED_PLUGINS_LOAD_ALL" desc="Button to load all
blocked plugins on a page, displayed in bubble when a page tries to display
plug-ins.">
        Run all plug-ins this time
      </message>

[Evan Stade, 2014-10-20 21:48:53]

On 2014/10/20 21:45:25, Chromium Palmer wrote:
> > In addition, we could change the string inside of a blocked plugin
placeholder
> > to say something like "Right-click to play <plugin>" or something.
> 
> Good idea. But, any idea where that string (e.g. "Chrome PDF Viewer is not
> allowed") is defined? I can't find it in a seemingly exhaustive search.
> 
> ~/chromium/src $ search -n '\.grd$' -c 'is not allowed' -v
> ./chrome/app/generated_resources.grd:2344:      <message
> name="IDS_BLOCKED_COOKIES_TITLE" desc="Tooltip and bubble info header text
when
> a page is not allowed to write cookies or other site data.">
> ./chrome/app/generated_resources.grd:2356:      <message
> name="IDS_BLOCKED_IMAGES_TITLE" desc="Tooltip and bubble info header text when
a
> page is not allowed to display images.">
> ./chrome/app/generated_resources.grd:2374:      <message
> name="IDS_BLOCKED_POPUPS_TOOLTIP" desc="Tooltip text when a page is not
allowed
> to display popups.">
> ./chrome/app/generated_resources.grd:2377:      <message
> name="IDS_BLOCKED_POPUPS_TITLE" desc="Bubble info header text when a page is
not
> allowed to display popups.  This appears above a list of popup titles.">
> ./chrome/app/generated_resources.grd:2440:      <message
> name="IDS_BLOCKED_JAVASCRIPT_TITLE" desc="Tooltip and bubble info header text
> when a page is not allowed to run JavaScript.">
> ./chrome/app/generated_resources.grd:2453:        <message
> name="IDS_BLOCKED_PLUGINS_TITLE" desc="Bubble info header text when a page is
> not allowed to display plug-ins.">
> ./chrome/app/generated_resources.grd:2457:      <message
> name="IDS_BLOCKED_PLUGINS_MESSAGE" desc="Tooltip and message when a page is
not
> allowed to display plug-ins.">
> ./chrome/app/generated_resources.grd:4545:        <message
> name="IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT" desc="Error message
> when a user tries to install or the administrator tries to force-install
through
> policy an extension that is not allowed in a device-local account.">
> ./chrome/app/generated_resources.grd:4546:          <ph
> name="EXTENSION_NAME">$1<ex>Google Talk</ex></ph> (extension ID "<ph
> name="EXTENSION_ID">$2<ex>nckgahadagoaajjgafhacjanaoiihapd</ex></ph>") is not
> allowed in this type of session.
> ./chrome/app/generated_resources.grd:4564:      <message
> name="IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE" desc="Error displayed during
> installation of an extension when installation is not allowed from the current
> site.">
> ./chrome/app/generated_resources.grd:4580:        Unable to install "<ph
> name="APP_NAME">$1<ex>Google Play Movies &amp; TV</ex></ph>" because it is not
> allowed by "<ph name="IMPORT_NAME">$2<ex>Google Cast API</ex></ph>"
> ./chrome/app/generated_resources.grd:6819:        <ph
> name="PLUGIN_NAME">$1<ex>Flash</ex></ph> is not allowed.
> ./chrome/app/generated_resources.grd:11653:      <message
> name="IDS_SYNC_LOGIN_NAME_PROHIBITED" desc="The error message shown when the
> user tries to sign in to sync using a name that is not allowed by the admin
> policy">
> ./chrome/app/generated_resources.grd:12337:          Empty passphrase is not
> allowed.
> ./chrome/app/generated_resources.grd:14733:    <message
> name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_PHONE_UNLOCKABLE" desc="Tooltip for
an
> icon on a user's lock screen pod shown by Easy Unlock when a phone eligible to
> unlock the Chromebook is detected, but it does not have lock screen enabled,
in
> which case it is not allowed to unlock Chromebooks.">
> ./chrome/app/generated_resources.grd
> 
> ~/chromium/src $ search -x/out/ -c 'is not allowed'                           
 
>                                                                               
 
>                                          
> 
> ~/chromium/src $
> 
> Note that IDS_BLOCKED_PLUGINS_MESSAGE and friends, which seems likely, are:
> 
>       <if expr="is_macosx">
>         <message name="IDS_BLOCKED_PLUGINS_TITLE" desc="Bubble info header
text
> when a page is not allowed to display plug-ins.">
>           The following plug-ins were blocked on this page:
>         </message>
>       </if>
>       <message name="IDS_BLOCKED_PLUGINS_MESSAGE" desc="Tooltip and message
when
> a page is not allowed to display plug-ins.">
>         Plug-ins were blocked on this page.
>       </message>
>       <message name="IDS_BLOCKED_PLUGINS_UNBLOCK_ALL" desc="Radio button
choice
> to unblock a site from using plug-ins, displayed in bubble when a page tries
to
> use plug-ins.">
>         Always allow plug-ins on <ph
name="HOST">$1<ex>mail.google.com</ex></ph>
>       </message>
>       <if expr="is_macosx">
>         <message name="IDS_BLOCKED_PLUGINS_UNBLOCK" desc="Radio button choice
to
> unblock a site from using *a specific set* of plug-ins, displayed in bubble
when
> a page tries to use plug-ins.">
>           Always allow these plug-ins on <ph
> name="HOST">$1<ex>mail.google.com</ex></ph>
>         </message>
>       </if>
>       <message name="IDS_BLOCKED_PLUGINS_NO_ACTION" desc="Radio button choice
to
> continue blocking a site from using plug-ins, displayed in bubble when a page
> tries to use plug-ins.">
>         Continue blocking plug-ins
>       </message>
>       <message name="IDS_BLOCKED_PLUGINS_LINK" desc="Link to plug-ins section
of
> content blocking management dialog, displayed in bubble when a page tries to
> display plug-ins.">
>         Manage plug-in blocking...
>       </message>
>       <message name="IDS_BLOCKED_PLUGINS_LOAD_ALL" desc="Button to load all
> blocked plugins on a page, displayed in bubble when a page tries to display
> plug-ins.">
>         Run all plug-ins this time
>       </message>

IDS_PLUGIN_BLOCKED in chrome/app/generated_resources.grd

[palmer, 2014-10-20 22:47:49]

> IDS_PLUGIN_BLOCKED in chrome/app/generated_resources.grd

Done.

[Bernhard Bauer, 2014-10-21 08:09:44]

lgtm

[Evan Stade, 2014-10-21 18:02:01]

lgtm

[palmer, 2014-10-21 19:20:30]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:21:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666523004/60001

[commit-bot: I haz the power, 2014-10-21 22:13:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-21 22:14:51]

Patchset 4 (id:??) landed as
https://crrev.com/826e7f6db664fd9f04f63192026afd4b5ec6a437
Cr-Commit-Position: refs/heads/master@{#300558}