Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 666513002: Allow forcing TestWebServer to use a specific port number. (Closed)

Created:
6 years, 2 months ago by Raphael Kubo da Costa (rakuco)
Modified:
6 years, 2 months ago
Reviewers:
hush (inactive), Yaron
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow forcing TestWebServer to use a specific port number. Commit c4a3f88c4434e86057a8c7ae4e109b8be4138d8f ("TestWebServer needs to use a free port") has caused TestWebServer to use a random port number in each invocation. This does not play well with tests that assume the server will be running on a specific port (for example, an HTML asset trying to do XHR whose contents cannot be changed at runtime). start() and startSsl() can now be passed an optional port number; if it is being used, the server will fail to start like it did before the commit mentioned above. R=hush@chromium.org, yfriedman@chromium.org Committed: https://crrev.com/b4e712c20bf06821c8a05c78886b3fc7dd96b887 Cr-Commit-Position: refs/heads/master@{#300151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 5 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Raphael Kubo da Costa (rakuco)
PTAL Unfortunately the problem I'm trying to fix does not affect any test in android_webview/, ...
6 years, 2 months ago (2014-10-17 16:02:47 UTC) #1
Yaron
lgtm
6 years, 2 months ago (2014-10-17 19:02:05 UTC) #2
hush (inactive)
lgtm thanks!
6 years, 2 months ago (2014-10-17 19:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666513002/1
6 years, 2 months ago (2014-10-17 19:30:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:04:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:06:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4e712c20bf06821c8a05c78886b3fc7dd96b887
Cr-Commit-Position: refs/heads/master@{#300151}

Powered by Google App Engine
This is Rietveld 408576698