Issue 6665067: [Arguments] Remove synthetic properties and all code dealing with them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6665067: [Arguments] Remove synthetic properties and all code dealing with them. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental

Visibility:
Public.

Description

[Arguments] Remove synthetic properties and all code dealing with them. This is all dead code since parameters do not rewrite to arguments. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7277

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -700 lines)			Patch
M	arguments/src/arm/codegen-arm.cc	View	1 chunk	+23 lines, -34 lines	0 comments	Download
M	arguments/src/arm/full-codegen-arm.cc	View	17 chunks	+28 lines, -173 lines	0 comments	Download
M	arguments/src/ast.h	View	4 chunks	+2 lines, -19 lines	0 comments	Download
M	arguments/src/hydrogen.cc	View	1 chunk	+6 lines, -12 lines	0 comments	Download
M	arguments/src/ia32/codegen-ia32.cc	View	1 chunk	+28 lines, -38 lines	0 comments	Download
M	arguments/src/ia32/full-codegen-ia32.cc	View	16 chunks	+27 lines, -181 lines	0 comments	Download
M	arguments/src/prettyprinter.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
	arguments/src/scopes.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	arguments/src/scopes.cc	View	2 chunks	+4 lines, -3 lines	1 comment	Download
M	arguments/src/variables.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	arguments/src/variables.cc	View	1 chunk	+5 lines, -16 lines	0 comments	Download
M	arguments/src/x64/codegen-x64.cc	View	1 chunk	+27 lines, -37 lines	0 comments	Download
M	arguments/src/x64/full-codegen-x64.cc	View	15 chunks	+26 lines, -177 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

I'm not doing anything with the classic code generator except keeping it compiling.

9 years, 9 months ago (2011-03-17 14:41:24 UTC) #1

Kevin Millikin (Chromium)

http://codereview.chromium.org/6665067/diff/1/arguments/src/scopes.cc File arguments/src/scopes.cc (right): http://codereview.chromium.org/6665067/diff/1/arguments/src/scopes.cc#newcode910 arguments/src/scopes.cc:910: ASSERT(var->rewrite() == NULL || I honestly don't understand why ...

9 years, 9 months ago (2011-03-17 14:44:08 UTC) #2

LGTM

Expand Messages | Collapse Messages