Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 6665063: [Isolates] Fix the crash in AssertNoContextChange ctor when current context i... (Closed)

Created:
9 years, 9 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
CC:
v8-dev, antonm
Visibility:
Public.

Description

[Isolates] Fix the crash in AssertNoContextChange ctor when current context is NULL. Committed: http://code.google.com/p/v8/source/detail?r=7249

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/isolate.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Titov
I'm getting a crash that I am not sure how to fix better. Attaching a ...
9 years, 9 months ago (2011-03-17 03:40:23 UTC) #1
Dmitry Titov
To repro the crash, one need to run more then one test from that dir, ...
9 years, 9 months ago (2011-03-17 03:42:35 UTC) #2
Vitaly Repeshko
LGTM (with comments) as a quick fix. Anton is probably right that we should change ...
9 years, 9 months ago (2011-03-17 18:13:42 UTC) #3
Dmitry Titov
9 years, 9 months ago (2011-03-17 20:19:08 UTC) #4
Thanks!

Fixed as suggested and landed.

Powered by Google App Engine
This is Rietveld 408576698