Chromium Code Reviews
Help | Chromium Project | Sign in
(11)

Issue 6665029: Adds a TransportDIB::Id value that is explicitly invalid and use it when compositing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by jamesr (out of office)
Modified:
2 years, 10 months ago
Reviewers:
brettw, Elliot Glaysher
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Adds a TransportDIB::Id value that is explicitly invalid and use it when compositing

BUG=76001
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79349

Patch Set 1 #

Patch Set 2 : compiles on windows #

Total comments: 2

Patch Set 3 : Makes default constructed TransportDIB::Ids invalid without special factory #

Patch Set 4 : compile fix for win #

Patch Set 5 : compile fix for mac #

Patch Set 6 : mebbe this one compiles? #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -28 lines) Lint Patch
M app/surface/accelerated_surface_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments ? errors Download
M app/surface/transport_dib.h View 1 2 3 chunks +16 lines, -3 lines 1 comment ? errors Download
M app/surface/transport_dib_linux.cc View 1 2 5 chunks +14 lines, -10 lines 0 comments 0 errors Download
M app/surface/transport_dib_mac.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments 0 errors Download
M app/surface/transport_dib_win.cc View 1 2 3 2 chunks +7 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 1 chunk +4 lines, -1 line 0 comments 0 errors Download
M content/browser/renderer_host/accelerated_surface_container_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
M content/browser/renderer_host/mock_render_process_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments 0 errors Download
M content/common/common_param_traits.h View 1 2 1 chunk +18 lines, -0 lines 1 comment ? errors Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
M content/plugin/webplugin_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments 0 errors Download
M content/renderer/render_widget.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
jamesr (out of office)
Interested in feedback - this isn't necessarily ready to commit yet as I haven't figured ...
3 years, 1 month ago #1
brettw
http://codereview.chromium.org/6665029/diff/2001/app/surface/transport_dib_win.cc File app/surface/transport_dib_win.cc (right): http://codereview.chromium.org/6665029/diff/2001/app/surface/transport_dib_win.cc#newcode65 app/surface/transport_dib_win.cc:65: return Id(DefaultHandleValue(), 0); It seems like this should just ...
3 years, 1 month ago #2
jamesr (out of office)
On 2011/03/17 03:31:00, brettw wrote: > http://codereview.chromium.org/6665029/diff/2001/app/surface/transport_dib_win.cc > File app/surface/transport_dib_win.cc (right): > > http://codereview.chromium.org/6665029/diff/2001/app/surface/transport_dib_win.cc#newcode65 > ...
3 years, 1 month ago #3
brettw
On 2011/03/17 04:17:31, jamesr wrote: > On 2011/03/17 03:31:00, brettw wrote: > > > http://codereview.chromium.org/6665029/diff/2001/app/surface/transport_dib_win.cc ...
3 years, 1 month ago #4
jamesr (out of office)
This ensures that dib_id is invalid if created like this: TransportDIB::Id dib_id; on all platforms ...
3 years ago #5
brettw
3 years ago #6
LGTM

http://codereview.chromium.org/6665029/diff/6019/app/surface/transport_dib.h
File app/surface/transport_dib.h (right):

http://codereview.chromium.org/6665029/diff/6019/app/surface/transport_dib.h#...
app/surface/transport_dib.h:103: bool operator< (const Id& other) const {
I think normal style would be no space afer the <

http://codereview.chromium.org/6665029/diff/6019/content/common/common_param_...
File content/common/common_param_traits.h (right):

http://codereview.chromium.org/6665029/diff/6019/content/common/common_param_...
content/common/common_param_traits.h:394: return (ReadParam(m, iter,
&r->shmkey));
I wouldn't do the extra parens around ReadParam.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6