tools/clang/blink_gc_plugin/tests/fields_require_tracing.h - Issue 666473003: Blink GC plugin: Gracefully handle cyclic part objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/fields_require_tracing.h

Issue 666473003: Blink GC plugin: Gracefully handle cyclic part objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/crash_on_invalid.txt ('k') | tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/fields_require_tracing.h

diff --git a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.h b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.h

index fe5b8d91c4b5b63107dc0333b926df91f6ffafee..60caa68042b4110a5d9e8d20cff0aa97a7813531 100644

--- a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.h

+++ b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.h

@@ -10,6 +10,16 @@

namespace blink {

class HeapObject;

+class PartObject;

+class PartBObject {

+ DISALLOW_ALLOCATION();

+public:

+ void trace(Visitor*);

+private:

+ HeapHashSet<PartBObject> m_set;

+ HeapVector<PartBObject> m_vector;

+};

class PartObject {

DISALLOW_ALLOCATION();

@@ -19,6 +29,8 @@ private:

Member<HeapObject> m_obj1;

Member<HeapObject> m_obj2;

Member<HeapObject> m_obj3;

+ HeapVector<PartBObject> m_parts;

};

class HeapObject : public GarbageCollected<HeapObject> {