third_party/polymer/PRESUBMIT.py - Issue 666453002: Removed Polymer elements depending on web-animations-js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/PRESUBMIT.py

Issue 666453002: Removed Polymer elements depending on web-animations-js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/polymer/PRESUBMIT.py

diff --git a/third_party/polymer/PRESUBMIT.py b/third_party/polymer/PRESUBMIT.py

index cc99f2b26387fe209a464a66b4882d802cbeb99d..6ca4c014c6a76ea7d3ee603e6f61706e4650de4f 100644

--- a/third_party/polymer/PRESUBMIT.py

+++ b/third_party/polymer/PRESUBMIT.py

@@ -27,9 +27,6 @@ def _CheckBowerDependencies(input_api, output_api):

bower_dependencies = \

set(json.load(open(bower_json_path))['dependencies'].keys())

installed_components = set(p for p in os.listdir(components_dir))

- # Add web-animations-js because we keep it in a separate directory

- # '../third_party/web-animations-js'.

- installed_components.add('web-animations-js')

if bower_dependencies == installed_components:

return []

« no previous file with comments | « no previous file | third_party/polymer/README.chromium » ('j') | no next file with comments »