Issue 666433002: Revert of Use count strings as keyframes/animation-name identifiers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 666433002: Revert of Use count strings as keyframes/animation-name identifiers (Closed)

Created:
6 years, 2 months ago by eustas

Modified:
6 years, 2 months ago

Reviewers:
dstockwell, Timothy Loh, alancutter (OOO until 2018)

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert of Use count strings as keyframes/animation-name identifiers (patchset #2 id:20001 of https://codereview.chromium.org/651123003/) Reason for revert: Seems to cause crash: https://code.google.com/p/chromium/issues/detail?id=424520 Original issue's description: > Use count strings as keyframes/animation-name identifiers > > Strings are not valid keyframes/animation-name identifiers. This change > tracks the occurrence of these strings in the wild to provide data > on the impact dropping support for this would have. > > BUG=423424 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183856 TBR=timloh@chromium.org,dstockwell@chromium.org,alancutter@chromium.org NOTREECHECKS=true NOTRY=true BUG=423424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183877

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	Source/core/css/parser/CSSGrammar.y	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

eustas

Created Revert of Use count strings as keyframes/animation-name identifiers

6 years, 2 months ago (2014-10-17 10:50:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666433002/1

6 years, 2 months ago (2014-10-17 10:51:52 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 10:52:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183877