Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 66643004: Remove QualifiedName argument from most HTMLElement::create functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hack for XML prefix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 08a3bc7570c4da0a5c232a2a10bf7d87e8176b06..08de712583726bdb85064b38b5c91980faa4f546 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -64,8 +64,8 @@ using namespace HTMLNames;
// Upper limit agreed upon with representatives of Opera and Mozilla.
static const unsigned maxSelectItems = 10000;
-HTMLSelectElement::HTMLSelectElement(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser)
- : HTMLFormControlElementWithState(tagName, document, form)
+HTMLSelectElement::HTMLSelectElement(Document& document, HTMLFormElement* form, bool createdByParser)
+ : HTMLFormControlElementWithState(selectTag, document, form)
, m_typeAhead(this)
, m_size(0)
, m_lastOnChangeIndex(-1)
@@ -77,19 +77,17 @@ HTMLSelectElement::HTMLSelectElement(const QualifiedName& tagName, Document& doc
, m_shouldRecalcListItems(false)
, m_isParsingInProgress(createdByParser)
{
- ASSERT(hasTagName(selectTag));
ScriptWrappable::init(this);
}
PassRefPtr<HTMLSelectElement> HTMLSelectElement::create(Document& document)
{
- return adoptRef(new HTMLSelectElement(selectTag, document, 0, false));
+ return adoptRef(new HTMLSelectElement(document, 0, false));
}
-PassRefPtr<HTMLSelectElement> HTMLSelectElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser)
+PassRefPtr<HTMLSelectElement> HTMLSelectElement::create(Document& document, HTMLFormElement* form, bool createdByParser)
{
- ASSERT(tagName.matches(selectTag));
- return adoptRef(new HTMLSelectElement(tagName, document, form, createdByParser));
+ return adoptRef(new HTMLSelectElement(document, form, createdByParser));
}
const AtomicString& HTMLSelectElement::formControlType() const

Powered by Google App Engine
This is Rietveld 408576698