Remove QualifiedName argument from most HTMLElement::create functions

Source/core/dom/Element.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 204 matching lines @@
     PassRefPtr<Attr> ensureAttr(const QualifiedName&);
 
     const Vector<RefPtr<Attr> >& attrNodeList();
 
     CSSStyleDeclaration* style();
 
     const QualifiedName& tagQName() const { return m_tagName; }
     String tagName() const { return nodeName(); }
     bool hasTagName(const QualifiedName& tagName) const { return m_tagName.matches(tagName); }
 
+    // Should be called only by Document::createElementNS to fix up m_tagName immediately after construction.
+    void setTagNameForCreateElementNS(const QualifiedName&);
+
     // A fast function for checking the local name against another atomic string.
     bool hasLocalName(const AtomicString& other) const { return m_tagName.localName() == other; }
     bool hasLocalName(const QualifiedName& other) const { return m_tagName.localName() == other.localName(); }
 
     virtual const AtomicString& localName() const OVERRIDE { return m_tagName.localName(); }
     virtual const AtomicString& prefix() const OVERRIDE { return m_tagName.prefix(); }
     virtual const AtomicString& namespaceURI() const OVERRIDE { return m_tagName.namespaceURI(); }
 
     virtual KURL baseURI() const OVERRIDE FINAL;
 
@@ skipping 619 matching lines @@
 {
     if (!elementData())
         return 0;
     if (elementData()->m_presentationAttributeStyleIsDirty)
         updatePresentationAttributeStyle();
     // Need to call elementData() again since updatePresentationAttributeStyle()
     // might swap it with a UniqueElementData.
     return elementData()->presentationAttributeStyle();
 }
 
+inline void Element::setTagNameForCreateElementNS(const QualifiedName& tagName)

[eseidel, 2013/11/11 23:31:04]

We could also just call this setPrefix... :)

[adamk, 2013/11/11 23:33:04]

I agree that the name could use improvement...but can we wait till this lands
via the CQ and fix up naming then?

+{
+    // We expect this method to be called only to reset the prefix.
+    ASSERT(tagName.localName() == m_tagName.localName());
+    ASSERT(tagName.namespaceURI() == m_tagName.namespaceURI());
+    m_tagName = tagName;
+}
+
 inline bool isShadowHost(const Node* node)
 {
     return node && node->isElementNode() && toElement(node)->shadow();
 }
 
 inline bool isShadowHost(const Element* element)
 {
     return element && element->shadow();
 }
 
 } // namespace
 
 #endif