Remove QualifiedName argument from most HTMLElement::create functions

Source/build/scripts/make_element_factory.py

 #!/usr/bin/env python
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 51 matching lines @@
         self._outputs.update({
             (self.namespace + 'ElementFactory.h'): self.generate_factory_header,
             (self.namespace + 'ElementFactory.cpp'): self.generate_factory_implementation,
             ('V8' + self.namespace + 'ElementWrapperFactory.h'): self.generate_wrapper_factory_header,
             ('V8' + self.namespace + 'ElementWrapperFactory.cpp'): self.generate_wrapper_factory_implementation,
         })
 
         fallback_interface = self.tags_in_file.parameters['fallbackInterfaceName'].strip('"')
         fallback_js_interface = self.tags_in_file.parameters['fallbackJSInterfaceName'].strip('"') or fallback_interface
 
-        for tag in self._template_context['tags']:
+        interface_counts = {}
+        tags = self._template_context['tags']
+        for tag in tags:
             tag['has_js_interface'] = self._has_js_interface(tag)
             tag['js_interface'] = self._js_interface(tag)
             tag['interface'] = self._interface(tag)
+            if tag['interface'] not in interface_counts:
+                interface_counts[tag['interface']] = 1
+            else:
+                interface_counts[tag['interface']] += 1

[abarth-chromium, 2013/11/09 01:54:50]

There's some fancier Pythony way of doing this.

[adamk, 2013/11/11 20:33:28]

Found two ways to do this. defaultdict seems to be the older one, so I used that
(Counter is the new stuff, but I don't need any of its fancy features).

+
+        for tag in tags:
+            tag['multipleTagNames'] = interface_counts[tag['interface']] > 1
 
         self._template_context.update({
             'fallback_interface': fallback_interface,
             'fallback_js_interface': fallback_js_interface,
         })
 
     @template_expander.use_jinja('ElementFactory.h.tmpl', filters=filters)
     def generate_factory_header(self):
         return self._template_context
 
@@ skipping 26 matching lines @@
         if tag['JSInterfaceName']:
             return tag['JSInterfaceName']
         return self._interface(tag)
 
     def _has_js_interface(self, tag):
         return not tag['mapToTagName'] and not tag['noConstructor'] and self._js_interface(tag) != ('%sElement' % self.namespace)
 
 
 if __name__ == "__main__":
     in_generator.Maker(MakeElementFactoryWriter).main(sys.argv)