Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 666403002: Decouple content transform fiddling from SVGRenderingContext::renderSubtree (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Decouple content transform fiddling from SVGRenderingContext::renderSubtree The "content transform" is essentially a property of the call-site, and is hence invariant for a sequence of calls to renderSubtree. This means we ought to be able to save-mutate-restore (SMR) once per call-site, and not per call to renderSubtree. Achieve this by moving the SMR to a helper SubtreeContentTransformScope, and then instantiate objects where needed. This means the transform-logistics can be cleaned up a bit for some of the callers. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.h View 2 chunks +11 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 2 chunks +15 lines, -10 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
@fmalita: Since we touched upon the contentTransform in the DL-pattern review, I hacked this up? ...
6 years, 2 months ago (2014-10-22 15:21:44 UTC) #2
f(malita)
On 2014/10/22 15:21:44, fs wrote: > @fmalita: Since we touched upon the contentTransform in the ...
6 years, 2 months ago (2014-10-22 17:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666403002/1
6 years, 2 months ago (2014-10-23 08:36:37 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 08:40:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184245

Powered by Google App Engine
This is Rietveld 408576698