Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.h

Issue 666363002: DeviceSettingsProvider's write path uses OwnerSettingsService now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_provider.h
diff --git a/chrome/browser/chromeos/settings/device_settings_provider.h b/chrome/browser/chromeos/settings/device_settings_provider.h
index b4aef5640893d3476610d8e0811656be76ba2e03..9ffeb6ff0c7a1d546728d16f6c7e39d087f983fb 100644
--- a/chrome/browser/chromeos/settings/device_settings_provider.h
+++ b/chrome/browser/chromeos/settings/device_settings_provider.h
@@ -5,9 +5,7 @@
#ifndef CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
#define CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
-#include <deque>
#include <string>
-#include <utility>
#include <vector>
#include "base/basictypes.h"
@@ -74,11 +72,6 @@ class DeviceSettingsProvider
// availability before the policy blob is fetched on boot.
void RetrieveCachedData();
- // Stores a value from the |pending_changes_| queue in the device settings.
- // If the device is not owned yet the data ends up only in the local_state
- // cache and is serialized once ownership is acquired.
- void SetInPolicy();
-
// Parses the policy data and fills in |values_cache_|.
void UpdateValuesCache(
const enterprise_management::PolicyData& policy_data,
@@ -117,10 +110,6 @@ class DeviceSettingsProvider
// if new settings have been loaded.
bool UpdateFromService();
- // Sends |device_settings_| to |device_settings_service_| for signing and
- // storage in session_manager.
- void StoreDeviceSettings();
-
// Checks the current ownership status to see whether the device owner is
// logged in and writes the data accumulated in |migration_values_| to proper
// device settings.
@@ -135,22 +124,19 @@ class DeviceSettingsProvider
TrustedStatus trusted_status_;
DeviceSettingsService::OwnershipStatus ownership_status_;
- // The device settings as currently reported through the CrosSettingsProvider
- // interface. This may be different from the actual current device settings
- // (which can be obtained from |device_settings_service_|) in case the device
- // does not have an owner yet or there are pending changes that have not yet
- // been written to session_manager.
+ // The device settings as currently reported through the
+ // CrosSettingsProvider interface. This may be different from the
+ // actual current device settings (which can be obtained from
+ // |device_settings_service_|) in case the device does not have an
+ // owner yet. As soon as ownership of the device will be taken,
+ // |device_settings_| will stored on disk and won't be used.
enterprise_management::ChromeDeviceSettingsProto device_settings_;
// A cache of values, indexed by the settings keys served through the
- // CrosSettingsProvider interface. This is always kept in sync with the raw
- // data found in |device_settings_|.
+ // CrosSettingsProvider interface. This is always kept in sync with the
+ // current device settings.
PrefValueMap values_cache_;
- // This is a queue for set requests, because those need to be sequential.
- typedef std::pair<std::string, base::Value*> PendingQueueElement;
- std::deque<PendingQueueElement> pending_changes_;
-
// Weak pointer factory for creating store operation callbacks.
base::WeakPtrFactory<DeviceSettingsProvider> store_callback_factory_;

Powered by Google App Engine
This is Rietveld 408576698