add getBounds to SkTypeface

add getBounds to SkTypeface

This uses SkLazyPtr, but to use it in a public header, I had to do move SkLazyPtr.h and SkThreadPriv.h into public :(

To use SkLazyPtr from a const method, I had to change its private ptr to mutable

[reed2, 2014-10-22 04:03:24]

reed@chromium.org changed reviewers:
+ bungeman@google.com, mtklein@google.com

[reed2, 2014-10-22 04:03:28]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2014-10-22 04:04:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666303002/1

[commit-bot: I haz the power, 2014-10-22 04:04:13]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-22 10:04 UTC

[reed2, 2014-10-22 04:05:32]

The CQ bit was unchecked by reed@chromium.org

[mtklein, 2014-10-22 14:46:19]

lgtm

https://codereview.chromium.org/666303002/diff/1/gm/fontmgr.cpp
File gm/fontmgr.cpp (right):

https://codereview.chromium.org/666303002/diff/1/gm/fontmgr.cpp#newcode249
gm/fontmgr.cpp:249: p.setColor(SK_ColorRED);
Might be nice to alternate red and another color so it's clear where the boxes
land for each font.

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h#ne...
include/core/SkTypeface.h:288: *  of the glyphs, each one positioned at (0,).
This may be conservatively large, and
and -> but?

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h#ne...
include/core/SkTypeface.h:373: friend struct BoundsComputer;
You might be able to get away without this friend declaration?  Can never
remember how nested classes friend each other.

[reed1, 2014-10-22 20:09:27]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-10-22 20:09:28]

abandoning in favor of https://codereview.chromium.org/676523002/

https://codereview.chromium.org/666303002/diff/1/gm/fontmgr.cpp
File gm/fontmgr.cpp (right):

https://codereview.chromium.org/666303002/diff/1/gm/fontmgr.cpp#newcode249
gm/fontmgr.cpp:249: p.setColor(SK_ColorRED);
On 2014/10/22 14:46:19, mtklein wrote:
> Might be nice to alternate red and another color so it's clear where the boxes
> land for each font.

Done.

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h#ne...
include/core/SkTypeface.h:288: *  of the glyphs, each one positioned at (0,).
This may be conservatively large, and
On 2014/10/22 14:46:19, mtklein wrote:
> and -> but?

Done.

https://codereview.chromium.org/666303002/diff/1/include/core/SkTypeface.h#ne...
include/core/SkTypeface.h:373: friend struct BoundsComputer;
On 2014/10/22 14:46:19, mtklein wrote:
> You might be able to get away without this friend declaration?  Can never
> remember how nested classes friend each other.

Done.