Add a Mojo recipe to make mojo fetch-able.

Add a Mojo recipe to make mojo fetch-able.

R=jamesr@chromium.org, agable@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292598

[Dirk Pranke, 2014-10-22 01:53:05]

Patchset #1 (id:1) has been deleted

[jamesr, 2014-10-22 04:00:12]

lgtm

Would you mind updating the readme in the mojo repo to say how to create a new
checkout using this tool? I'm not entirely sure how to specify that you want
android bits.

[Dirk Pranke, 2014-10-22 05:24:20]

On 2014/10/22 04:00:12, jamesr wrote:
> lgtm
> 
> Would you mind updating the readme in the mojo repo to say how to create a new
> checkout using this tool? I'm not entirely sure how to specify that you want
> android bits.

Will do. I believe it is just 'fetch mojo --target-os=android'.

[agable, 2014-10-22 10:54:37]

LGTM % some comments.

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py
File recipes/mojo.py (right):

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode19
recipes/mojo.py:19: 'name'   :'src',
Does mojo really want to be called src? If it doesn't require it, I'd suggest
calling it something else, probably just 'mojo'.

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode32
recipes/mojo.py:32: spec_type = '%s_spec' % checkout_type
Since there's no logic determining the checkout_type (e.g. it can't ever be
'gclient_git_svn', just hardcode these values directly in the return dictionary.
See the fetch infra recipe.

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode40
recipes/mojo.py:40: return 'src'
here too

[Dirk Pranke, 2014-10-22 16:19:28]

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py
File recipes/mojo.py (right):

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode19
recipes/mojo.py:19: 'name'   :'src',
On 2014/10/22 10:54:37, agable wrote:
> Does mojo really want to be called src? If it doesn't require it, I'd suggest
> calling it something else, probably just 'mojo'.

Good question. For now, yes, it does; the mojo checkout is basically a
stripped-down version of a chromium checkout, and it's easier to keep 'src' the
same across both. I'm not actually sure if anything *requires* 'src', but we can
dig into that later.

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode32
recipes/mojo.py:32: spec_type = '%s_spec' % checkout_type
On 2014/10/22 10:54:37, agable wrote:
> Since there's no logic determining the checkout_type (e.g. it can't ever be
> 'gclient_git_svn', just hardcode these values directly in the return
dictionary.
> See the fetch infra recipe.

Ok. I was cloning other recipes here for consistency, but I see you just changed
them in your other CL.  I prefer the hardcoded approach myself :).

https://codereview.chromium.org/666293002/diff/20001/recipes/mojo.py#newcode40
recipes/mojo.py:40: return 'src'
On 2014/10/22 10:54:37, agable wrote:
> here too

same answer :).

[Dirk Pranke, 2014-10-22 17:35:42]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:35:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666293002/40001

[commit-bot: I haz the power, 2014-10-22 17:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:37:44]

Presubmit check for 666293002-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (58.42s) failed
.......F......................................
======================================================================
FAIL: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1273, in testMultiSolutionsJobs
    results = self.splitBlock(stdout)
  File "tests/gclient_smoketest.py", line 117, in splitBlock
    self.fail(line)
AssertionError: __main__.GClientSmokeBoth.testMultiSolutionsJobs/src/other/DEPS

----------------------------------------------------------------------
Ran 46 tests in 58.218s

FAILED (failures=1)


push-basic.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   2175 --:--:-- --:--:-- --:--:--  2264
TESTING: Base URL contains branch name
TESTING: git-cl land ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:10000/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2892, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2878, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2264, in CMDland
    return SendUpstream(parser, args, 'land')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2132, in SendUpstream
    cl.RpcServer().add_comment(cl.GetIssue(), comment)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 260, in add_comment
    ('no_redirect', 'True')])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 390, in post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 416, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/third_party/upload.py",
line 464, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden
FAILURE: git-cl land ok


Presubmit checks took 103.6s to calculate.

[Dirk Pranke, 2014-10-22 17:46:56]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:47:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666293002/40001

[commit-bot: I haz the power, 2014-10-22 17:49:57]

Committed patchset #2 (id:40001) as 292598