Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 666283002: Android: Remove unused ZoomController, which also references extensions. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: Remove unused ZoomController, which also references extensions. BUG=424746 Committed: https://crrev.com/2c8c41e542e9fede5c613e44581ab5b320592052 Cr-Commit-Position: refs/heads/master@{#300828}

Patch Set 1 #

Patch Set 2 : fix case where ZoomController can be NULL, and rebase #

Patch Set 3 : tweak #includes #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/renderer_preferences_util.cc View 1 2 3 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 2 3 4 chunks +7 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Lei Zhang
6 years, 2 months ago (2014-10-21 23:57:33 UTC) #2
wjmaclean
lgtm
6 years, 2 months ago (2014-10-22 13:28:08 UTC) #3
wjmaclean
On 2014/10/22 13:28:08, wjmaclean wrote: > lgtm Btw, thanks!
6 years, 2 months ago (2014-10-22 18:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666283002/1
6 years, 2 months ago (2014-10-22 18:53:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/71170) linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/1724)
6 years, 2 months ago (2014-10-22 19:19:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666283002/1
6 years, 2 months ago (2014-10-22 19:29:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/71565) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/61626) mac_gpu_triggered_tests ...
6 years, 2 months ago (2014-10-22 19:59:54 UTC) #12
Lei Zhang
We don't always have ZoomControllers in non-Android builds. I patched up the code a bit ...
6 years, 2 months ago (2014-10-23 00:26:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666283002/40002
6 years, 2 months ago (2014-10-23 01:46:39 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:40002)
6 years, 2 months ago (2014-10-23 02:57:03 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 02:59:02 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2c8c41e542e9fede5c613e44581ab5b320592052
Cr-Commit-Position: refs/heads/master@{#300828}

Powered by Google App Engine
This is Rietveld 408576698