Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 666243002: Change mobile emulation 'mobile' setting to true. (Closed)

Created:
6 years, 2 months ago by srawlins
Modified:
6 years, 2 months ago
Reviewers:
samuong
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change mobile emulation 'mobile' setting to true. Also added viewport meta to some tests. Committed: https://crrev.com/9954da8a3f7abb0689ff9c91a6c8f6fd8494627f Cr-Commit-Position: refs/heads/master@{#300782}

Patch Set 1 #

Patch Set 2 : syncing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M chrome/test/chromedriver/chrome/device_metrics.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 2 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
srawlins
6 years, 2 months ago (2014-10-21 22:47:05 UTC) #2
samuong
On 2014/10/21 22:47:05, srawlins wrote: lgtm
6 years, 2 months ago (2014-10-21 23:39:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666243002/1
6 years, 2 months ago (2014-10-22 00:08:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/82094) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/71754) win_gpu ...
6 years, 2 months ago (2014-10-22 00:18:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666243002/20001
6 years, 2 months ago (2014-10-22 21:18:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 22:45:42 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 22:46:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9954da8a3f7abb0689ff9c91a6c8f6fd8494627f
Cr-Commit-Position: refs/heads/master@{#300782}

Powered by Google App Engine
This is Rietveld 408576698