Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 666213004: Send a 0 idle notification on context disposal (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
haraken, ulan
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Project:
blink
Visibility:
Public.

Description

Send a 0 idle notification on context disposal This simplifies the logic on the V8 side that tries to guess whether the idle notification comes from the compositor or from context disposal BUG=none R=ulan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/bindings/core/v8/V8GCForContextDispose.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-22 07:56:44 UTC) #1
ulan
lgtm
6 years, 2 months ago (2014-10-22 07:58:01 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-22 07:59:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666213004/1
6 years, 2 months ago (2014-10-23 09:31:34 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 10:33:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184253

Powered by Google App Engine
This is Rietveld 408576698