Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 666213003: HRTFDatabaseLoader needs to acquire a lock when accessing m_hrtfDatabase (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
CC:
blink-reviews, Raymond Toy, mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

HRTFDatabaseLoader needs to acquire a lock when accessing m_hrtfDatabase Currently HRTFDatabaseLoader::m_threadLock is acquired when accessing m_databaseLoaderThread, but the lock is not needed because m_databaseLoaderThread is not accessed by multiple threads. What we need to protect is not m_databaseLoaderThread but m_hrtfDatabase, which is accessed by multiple threads. This CL makes the fix. BUG=415305 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184166

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/platform/audio/HRTFDatabaseLoader.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.cpp View 1 2 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
haraken
Not directly related to the bug, this is a potential fix for threading races. PTAL.
6 years, 2 months ago (2014-10-22 05:19:17 UTC) #2
tkent
lgtm
6 years, 2 months ago (2014-10-22 05:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666213003/20001
6 years, 2 months ago (2014-10-22 05:56:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/14499) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/28053)
6 years, 2 months ago (2014-10-22 06:05:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666213003/40001
6 years, 2 months ago (2014-10-22 07:42:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/71295)
6 years, 2 months ago (2014-10-22 08:16:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666213003/40001
6 years, 2 months ago (2014-10-22 10:43:59 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 11:13:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184166

Powered by Google App Engine
This is Rietveld 408576698