Standardize usage of virtual/override/final in sandbox/

sandbox/mac/xpc_message_server_unittest.cc

Index: sandbox/mac/xpc_message_server_unittest.cc
diff --git a/sandbox/mac/xpc_message_server_unittest.cc b/sandbox/mac/xpc_message_server_unittest.cc
index af8280e4a21b493a798a390bdca358bcae693e09..d0409de18a09841d97d33225da35c01d9ee850bd 100644
--- a/sandbox/mac/xpc_message_server_unittest.cc
+++ b/sandbox/mac/xpc_message_server_unittest.cc
@@ -43,7 +43,7 @@ class BlockDemuxer : public MessageDemuxer {
         pipe_(NULL) {
   }
 
-  virtual ~BlockDemuxer() {
+  ~BlockDemuxer() override {
     if (pipe_)
       xpc_release(pipe_);
     if (demux_block_)
@@ -68,9 +68,7 @@ class BlockDemuxer : public MessageDemuxer {
     return true;
   }
 
-  virtual void DemuxMessage(IPCMessage request) override {
-    demux_block_(request);

[Robert Sesek, 2014/10/21 20:52:40]

nit: please leave on separate line

[dcheng, 2014/10/21 20:53:57]

How strongly do you feel about this? This is how clang-format prefers it, and
I'd prefer not to fight it, especially in giant patches like this.

[Robert Sesek, 2014/10/21 20:58:36]

This is less readable. I feel strongly about not caring about what clang-format
outputs.

[dcheng, 2014/10/21 21:01:11]

I'll revert this particular line. However, note it's generally impractical for
me to do this on a large scale--due to the nature of this patch, reflowing some
lines is almost always going to be required and reverting all instances of this
(as I was asked to do in ipc/) is time consuming.

[Robert Sesek, 2014/10/21 21:09:05]

Thanks. I appreciate that, but trading off readability for mechanized
convenience is not the right choice IMO.

-  }
+  void DemuxMessage(IPCMessage request) override { demux_block_(request); }
 
   xpc_pipe_t pipe() { return pipe_; }