Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 666173002: Revert of [chromedriver] Set mobile=true when calling setDeviceMetricsOverride (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao, srawlins
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromedriver] Set mobile=true when calling setDeviceMetricsOverride (patchset #1 id:1 of https://codereview.chromium.org/668783002/) Reason for revert: This is breaking mobile emulation tests (testDeviceMetrics and testDeviceName). For some reason, window.innerHeight/innerWidth get reported incorrectly when this patch is applied. Original issue's description: > [chromedriver] Set mobile=true when calling setDeviceMetricsOverride > > BUG=chromedriver:944 > TBR=stgao@chromium.org > > Committed: https://crrev.com/02d008b0ee86ef7037833d27cf92b45f9125f097 > Cr-Commit-Position: refs/heads/master@{#300390} TBR=srawlins@google.com,stgao@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromedriver:944 Committed: https://crrev.com/895619a90a778b576cce262d5c6b68c94c255a98 Cr-Commit-Position: refs/heads/master@{#300494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/chromedriver/chrome/device_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong
Created Revert of [chromedriver] Set mobile=true when calling setDeviceMetricsOverride
6 years, 2 months ago (2014-10-21 15:51:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666173002/1
6 years, 2 months ago (2014-10-21 15:52:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 15:54:19 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 15:54:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/895619a90a778b576cce262d5c6b68c94c255a98
Cr-Commit-Position: refs/heads/master@{#300494}

Powered by Google App Engine
This is Rietveld 408576698