DescriptionRevert of [chromedriver] Set mobile=true when calling setDeviceMetricsOverride (patchset #1 id:1 of https://codereview.chromium.org/668783002/)
Reason for revert:
This is breaking mobile emulation tests (testDeviceMetrics and testDeviceName). For some reason, window.innerHeight/innerWidth get reported incorrectly when this patch is applied.
Original issue's description:
> [chromedriver] Set mobile=true when calling setDeviceMetricsOverride
>
> BUG=chromedriver:944
> TBR=stgao@chromium.org
>
> Committed: https://crrev.com/02d008b0ee86ef7037833d27cf92b45f9125f097
> Cr-Commit-Position: refs/heads/master@{#300390}
TBR=srawlins@google.com,stgao@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:944
Committed: https://crrev.com/895619a90a778b576cce262d5c6b68c94c255a98
Cr-Commit-Position: refs/heads/master@{#300494}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|