Allow layers to signal that additional sequences are needed before surface destruction

cc/surfaces/surface.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface.h"
 
 #include <algorithm>
 
 #include "cc/output/compositor_frame.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/surfaces/surface_factory.h"
+#include "cc/surfaces/surface_id_allocator.h"
 #include "cc/surfaces/surface_manager.h"
 
 namespace cc {
 
+namespace {
+struct SatisfyChecker {
+  SatisfyChecker(base::hash_set<SurfaceSequence>* satisfied)

[jamesr, 2014/11/06 01:16:17]

explicit

+      : satisfied_(satisfied) {}
+
+  bool operator()(const SurfaceSequence& seq) {
+    auto it = satisfied_->find(seq);
+    if (it != satisfied_->end()) {
+      satisfied_->erase(it);
+      return true;
+    }
+    return false;
+  }
+  base::hash_set<SurfaceSequence>* satisfied_;
+};
+}  // namespace
+
 // The frame index starts at 2 so that empty frames will be treated as
 // completely damaged the first time they're drawn from.
 static const int kFrameIndexStart = 2;
 
 Surface::Surface(SurfaceId id, const gfx::Size& size, SurfaceFactory* factory)
     : surface_id_(id),
       size_(size),
       factory_(factory->AsWeakPtr()),
       frame_index_(kFrameIndexStart) {
 }
@@ skipping 24 matching lines @@
     ReturnedResourceArray previous_resources;
     TransferableResource::ReturnResources(
         previous_frame->delegated_frame_data->resource_list,
         &previous_resources);
     factory_->UnrefResources(previous_resources);
   }
   if (!draw_callback_.is_null())
     draw_callback_.Run();
   draw_callback_ = callback;
   factory_->manager()->DidSatisfySequences(
-      surface_id_, &current_frame_->metadata.satisfies_sequences);
+      SurfaceIdAllocator::NamespaceForId(surface_id_),
+      &current_frame_->metadata.satisfies_sequences);
 }
 
 void Surface::RequestCopyOfOutput(scoped_ptr<CopyOutputRequest> copy_request) {
   if (current_frame_ &&
       !current_frame_->delegated_frame_data->render_pass_list.empty())
     current_frame_->delegated_frame_data->render_pass_list.back()
         ->copy_requests.push_back(copy_request.Pass());
   else
     copy_request->SendEmptyResult();
 }
@@ skipping 33 matching lines @@
 }
 
 void Surface::RunDrawCallbacks() {
   if (!draw_callback_.is_null()) {
     base::Closure callback = draw_callback_;
     draw_callback_ = base::Closure();
     callback.Run();
   }
 }
 
+void Surface::AddDestructionDependency(SurfaceSequence sequence) {
+  destruction_dependencies_.push_back(sequence);
+}
+
+void Surface::SatisfyDestructionDependencies(
+    base::hash_set<SurfaceSequence>* sequences) {
+  destruction_dependencies_.erase(
+      std::remove_if(destruction_dependencies_.begin(),
+                     destruction_dependencies_.end(),
+                     SatisfyChecker(sequences)),

[jamesr, 2014/11/06 01:16:17]

i think this would be a good use case for a lambda, if you're up for that

+      destruction_dependencies_.end());
+}
+
 void Surface::ClearCopyRequests() {
   if (current_frame_) {
     for (const auto& render_pass :
          current_frame_->delegated_frame_data->render_pass_list) {
       for (const auto& copy_request : render_pass->copy_requests)
         copy_request->SendEmptyResult();
     }
   }
 }
 
 }  // namespace cc